Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support spread completions inside ternary and parenthesized expressions #14058

Merged
merged 1 commit into from
May 9, 2024
Merged

Support spread completions inside ternary and parenthesized expressions #14058

merged 1 commit into from
May 9, 2024

Conversation

anthony-c-martin
Copy link
Member

@anthony-c-martin anthony-c-martin commented May 9, 2024 •
edited by microsoft-github-policy-service bot
Loading

Closes #14056

Microsoft Reviewers: Open in CodeFlow

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2024 •
edited
Loading

Test this change out locally with the following install scripts (Action run 9021140293)

VSCode
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 9021140293
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 9021140293"
Azure CLI
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 9021140293
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 9021140293"

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2024

Dotnet Test Results

    66 files   -     33      66 suites   - 33   22m 26s ⏱️ - 10m 5s
10 885 tests  -     18  10 884 ✅  -     18  1 💤 ±0  0 ❌ ±0 
25 666 runs   - 12 823  25 664 ✅  - 12 822  2 💤  - 1  0 ❌ ±0 

Results for commit 96c0f89. ± Comparison against base commit 44e0c7d.

@anthony-c-martin anthony-c-martin changed the title Fix for issue 14056 Support spread completions inside ternary and parenthesized expressions May 9, 2024
StephenWeatherford
StephenWeatherford reviewed May 9, 2024
View reviewed changes
src/Bicep.Core/Syntax/SyntaxBase.cs
using Bicep.Core.Extensions;
using Bicep.Core.Parsing;
using JetBrains.Annotations;

namespace Bicep.Core.Syntax
{
[DebuggerDisplay("{GetDebuggerDisplay(),nq}")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-)

@anthony-c-martin anthony-c-martin merged commit d5328ee into main May 9, 2024
44 checks passed
@anthony-c-martin anthony-c-martin deleted the ant/issue14056 branch May 9, 2024 17:31
@anthony-c-martin anthony-c-martin mentioned this pull request May 12, 2024
Merged
anthony-c-martin added a commit that referenced this pull request May 15, 2024
@anthony-c-martin
Add test case for issue 14066 (#14074)
31f71a5 
Closes #14066 

This was already fixed with #14058 - I just wanted to include the sample
repro shared in #14066.
###### Microsoft Reviewers: [Open in
CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/14074)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenWeatherford StephenWeatherford StephenWeatherford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

intellisense for spread operator
2 participants
@anthony-c-martin @StephenWeatherford