adding support for variables, objects and arrays in extended param files

Azure · Dec 11, 2024 · 4147740 · 4147740
1 parent f0470b8
commit 4147740
Show file tree

Hide file tree

Showing 2 changed files with 70 additions and 1 deletion.
diff --git a/src/Bicep.Core.IntegrationTests/ParametersTests.cs b/src/Bicep.Core.IntegrationTests/ParametersTests.cs
@@ -546,5 +546,74 @@ param foo string
             }
             }"));
         }
+
+        [TestMethod]
+        public void Using_variables_objects_arrays_in_base_parameters_file_should_succeed()
+        {
+            var result = CompilationHelper.CompileParams(
+              ("bicepconfig.json", @"
+                {
+                    ""experimentalFeaturesEnabled"": {
+                        ""extendableParamFiles"": true
+                    }
+                }
+              "),
+              ("parameters.bicepparam", @"
+                using 'main.bicep'
+                extends 'shared.bicepparam'
+              "),
+              ("shared.bicepparam", @"
+                using none
+
+                var var_foo = 'foo'
+                param foo = var_foo
+
+                var var_bar = {
+                    a: 'a'
+                    b: 'b'
+                }
+
+                param bar = var_bar
+
+                var var_baz = [
+                    var_foo
+                    var_bar
+                ]
+
+                param baz = var_baz
+              "),
+              ("main.bicep", @"
+                param foo string = ''
+                param bar object = {}
+                param baz array = []
+              "));
+
+            result.ExcludingLinterDiagnostics().Should().NotHaveAnyDiagnostics();
+
+            result.Parameters.Should().DeepEqual(JToken.Parse(@"{
+                ""$schema"": ""https://schema.management.azure.com/schemas/2019-04-01/deploymentParameters.json#"",
+                ""contentVersion"": ""1.0.0.0"",
+                ""parameters"": {
+                    ""foo"": {
+                        ""value"": ""bar""
+                    },
+                    ""bar"": {
+                        ""value"": {
+                            ""a"": ""a"",
+                            ""b"": ""b""
+                        }
+                    },
+                    ""baz"": {
+                        ""value"": [
+                            ""foo"",
+                            {
+                                ""a"": ""a"",
+                                ""b"": ""b""
+                            }
+                        ]
+                    }
+                }
+            }"));
+        }
     }
 }
diff --git a/src/Bicep.Core/Semantics/SemanticModel.cs b/src/Bicep.Core/Semantics/SemanticModel.cs
@@ -570,7 +570,7 @@ private IEnumerable<IDiagnostic> GatherParameterMismatchDiagnostics(ISemanticMod
 
         private IEnumerable<IDiagnostic> GatherTypeMismatchDiagnostics()
         {
-            foreach (var assignmentSymbol in Root.ParameterAssignments)
+            foreach (var assignmentSymbol in Root.ParameterAssignments.Where(x => x.Context.SourceFile == Root.Context.SourceFile))
             {
                 if (assignmentSymbol.Type is not ErrorType &&
                     assignmentSymbol.Type is not NullType && // `param x = null` is equivalent to skipping the assignment altogether