Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New Module avm/res/insights/component #635

Merged
merged 10 commits into from
Nov 18, 2023

Conversation

krbar
Copy link
Contributor

@krbar krbar commented Nov 15, 2023

Description

New Module avm/res/insights/component, migrated from CARML.

Adding a new module

  • A proposal has been submitted and approved.
  • I have included "Closes #{module_proposal_issue_number}" in the PR description.
  • I have run brm validate locally to verify the module files.
  • I have run deployment tests locally to ensure the module is deployable.

Pipeline references

Pipeline
avm.res.insights.component

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Nov 15, 2023
@krbar krbar marked this pull request as ready for review November 16, 2023 12:21
@krbar krbar requested review from a team as code owners November 16, 2023 12:21
@krbar krbar requested a review from a team as a code owner November 16, 2023 20:42
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) November 18, 2023 08:56
@AlexanderSehr AlexanderSehr merged commit 431cd4b into Azure:main Nov 18, 2023
9 checks passed
@krbar krbar deleted the users/krbar/appInsightsModule branch November 18, 2023 11:33
segraef pushed a commit to segraef/bicep-registry-modules that referenced this pull request Nov 19, 2023
## Description

New Module `avm/res/insights/component`, migrated from CARML.

## Adding a new module

<!--Run through the checklist if your PR adds a new module.-->

- [x] A proposal has been submitted and approved.
- [ ] I have included "Closes #{module_proposal_issue_number}" in the PR
description.
- [x] I have run `brm validate` locally to verify the module files.
- [x] I have run deployment tests locally to ensure the module is
deployable.

## Pipeline references

| Pipeline |
| - |
|
[![avm.res.insights.component](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.insights.component.yml/badge.svg?branch=users%2Fkrbar%2FappInsightsModule)](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.insights.component.yml)
|

---------

Co-authored-by: Alexander Sehr <[email protected]>
@matebarabas matebarabas added Type: New Module Proposal 💡 A new module for AVM is being proposed Class: Resource Module 📦 This is a resource module and removed Needs: Triage 🔍 Maintainers need to triage still labels Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: New Module Proposal 💡 A new module for AVM is being proposed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants