Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: StorageAccount - Added allowed tier value, updated local user authorized key interface, added udts #3645

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Oct 26, 2024

Description

  • Added tier 'Cold'
  • Updated local user authorized key handling (secureList)
  • Added udts for local user & sub-objects

Depends on microsoft/PSRule#2591 & Release https://github.com/Azure/PSRule.Rules.Azure/milestone/127

Closes #3640
Closes #3629

Pipeline Reference

Pipeline
avm.res.storage.storage-account

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

@AlexanderSehr AlexanderSehr added Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Needs: Module Owner 📣 This module needs an owner to develop or maintain it Class: Resource Module 📦 This is a resource module labels Oct 26, 2024
@AlexanderSehr AlexanderSehr self-assigned this Oct 26, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Oct 26, 2024
@AlexanderSehr AlexanderSehr changed the title Added allowedValue, updated local user authorized key, added udts feat: StorageAccount - Added allowed tier value, updated local user authorized key interface, added udts Oct 26, 2024
@AlexanderSehr AlexanderSehr marked this pull request as ready for review October 26, 2024 09:04
@AlexanderSehr AlexanderSehr requested review from a team as code owners October 26, 2024 09:04
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) October 26, 2024 09:04
@AlexanderSehr AlexanderSehr removed the Needs: Triage 🔍 Maintainers need to triage still label Oct 26, 2024
@AlexanderSehr
Copy link
Contributor Author

@fblix / @ktremain please review when you get the chance. The PR closes to storage account issues.

Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hola @AlexanderSehr, what about integrating here also changes done in #3606 ?

@AlexanderSehr
Copy link
Contributor Author

Hola @AlexanderSehr, what about integrating here also changes done in #3606 ?

Can do, sure

@AlexanderSehr AlexanderSehr marked this pull request as draft October 26, 2024 19:17
auto-merge was automatically disabled October 26, 2024 19:17

Pull request was converted to draft

@jtracey93
Copy link
Contributor

Hey @AlexanderSehr ,

Firstly, thanks for your work on this PR!

We have made some changes to the AVM CI, detailed below, which means we need you to update your fork to pull in these latest changes and re-run your tests to show they still are passing prior to approving and merging this PR, as we don't and it fails once merged the publishing of your module will fail and will be blocked going forward until the test pass again via additional PRs.

Changes to CI That Have Been Made That You Need To Take Action On

Any questions reach out to the AVM Core Team by tagging us in your PR here or internally via Teams

Thanks

Jack (AVM Core Team)

@AlexanderSehr AlexanderSehr marked this pull request as ready for review November 28, 2024 22:13
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) November 28, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Needs: Module Owner 📣 This module needs an owner to develop or maintain it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
3 participants