Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Metadata for BRM Changes & Add Support for Subscription Request Creation for MCA Multi-Tenant Customers #42

Merged
merged 4 commits into from
Jun 13, 2023

Conversation

jtracey93
Copy link
Collaborator

Overview/Summary

Update Metadata for BRM Changes & Add Support for Subscription Request Creation for MCA Multi-Tenant Customers

This PR fixes/adds/changes/removes

  1. Changes template metadata for main.bicep for [Can't merge until next release] Modify brm tool to fully support description metadata for public registry modules bicep#10810 as below:
    a. metadata.summary > metadata.description
    b. metadata.description > metadata.details
  2. Added 2 new optional parameters for subscription alias resource to support this scenario

Breaking Changes

None

Testing Evidence

Tests will suffice

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • (LZ-Vending Core Team Only) Associated it with relevant ADO Items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated one or more of the following tests (if required)
  • Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Wiki Docs etc.)

@jtracey93 jtracey93 requested a review from a team as a code owner June 7, 2023 11:37
@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Jun 7, 2023
@jtracey93 jtracey93 added enhancement New feature or request Area: Bicep Registry and removed Needs: Triage 🔍 Needs triaging by the team labels Jun 7, 2023
@jtracey93 jtracey93 merged commit 75fc2e0 into main Jun 13, 2023
@jtracey93 jtracey93 deleted the feat-brm-metadata-changes branch June 13, 2023 09:21
shenglol pushed a commit to Azure/bicep-registry-modules that referenced this pull request Jun 13, 2023
…d add optional params for MCA Multi Tenant Scenario (#410)

## Description

lz (sub) vending `v1.4.1` release - Change Template Metadata and add
optional params for MCA Multi Tenant Scenario

## Downstream Artifcats

- Release: https://github.com/Azure/bicep-lz-vending/releases/tag/v1.4.1
- PR: Azure/bicep-lz-vending#42
- Tests:
https://github.com/Azure/bicep-lz-vending/actions/runs/5199625378/jobs/9377275161

cc: @StephenWeatherford and @shenglol 

## Updating an existing module

<!--Run through the checklist if your PR updates an existing module.-->

- [ ] This is a bug fix:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [x] I have run `brm validate` locally to verify the module files.
- [x] I have run deployment tests locally to ensure the module is
deployable.
- [x] I have read the [Updating an existing
module](https://github.com/Azure/bicep-registry-modules/blob/main/CONTRIBUTING.md#updating-an-existing-module)
section in the contributing guide and updated the `version.json` file
properly:
- [ ] The PR contains backwards compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`.
- [x] The PR contains backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] The PR contains breaking changes, and I have bumped the MAJOR
version in `version.json`.
- [x] I have updated the examples in README with the latest module
version number.
StephenWeatherford pushed a commit to StephenWeatherford/bicep-registry-modules that referenced this pull request Jul 21, 2023
…d add optional params for MCA Multi Tenant Scenario (Azure#410)

## Description

lz (sub) vending `v1.4.1` release - Change Template Metadata and add
optional params for MCA Multi Tenant Scenario

## Downstream Artifcats

- Release: https://github.com/Azure/bicep-lz-vending/releases/tag/v1.4.1
- PR: Azure/bicep-lz-vending#42
- Tests:
https://github.com/Azure/bicep-lz-vending/actions/runs/5199625378/jobs/9377275161

cc: @StephenWeatherford and @shenglol 

## Updating an existing module

<!--Run through the checklist if your PR updates an existing module.-->

- [ ] This is a bug fix:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [x] I have run `brm validate` locally to verify the module files.
- [x] I have run deployment tests locally to ensure the module is
deployable.
- [x] I have read the [Updating an existing
module](https://github.com/Azure/bicep-registry-modules/blob/main/CONTRIBUTING.md#updating-an-existing-module)
section in the contributing guide and updated the `version.json` file
properly:
- [ ] The PR contains backwards compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`.
- [x] The PR contains backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] The PR contains breaking changes, and I have bumped the MAJOR
version in `version.json`.
- [x] I have updated the examples in README with the latest module
version number.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants