-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Metadata for BRM Changes & Add Support for Subscription Request Creation for MCA Multi-Tenant Customers #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtracey93
added
enhancement
New feature or request
Area: Bicep Registry
and removed
Needs: Triage 🔍
Needs triaging by the team
labels
Jun 7, 2023
matt-FFFFFF
approved these changes
Jun 9, 2023
10 tasks
shenglol
pushed a commit
to Azure/bicep-registry-modules
that referenced
this pull request
Jun 13, 2023
…d add optional params for MCA Multi Tenant Scenario (#410) ## Description lz (sub) vending `v1.4.1` release - Change Template Metadata and add optional params for MCA Multi Tenant Scenario ## Downstream Artifcats - Release: https://github.com/Azure/bicep-lz-vending/releases/tag/v1.4.1 - PR: Azure/bicep-lz-vending#42 - Tests: https://github.com/Azure/bicep-lz-vending/actions/runs/5199625378/jobs/9377275161 cc: @StephenWeatherford and @shenglol ## Updating an existing module <!--Run through the checklist if your PR updates an existing module.--> - [ ] This is a bug fix: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [x] I have run `brm validate` locally to verify the module files. - [x] I have run deployment tests locally to ensure the module is deployable. - [x] I have read the [Updating an existing module](https://github.com/Azure/bicep-registry-modules/blob/main/CONTRIBUTING.md#updating-an-existing-module) section in the contributing guide and updated the `version.json` file properly: - [ ] The PR contains backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`. - [x] The PR contains backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] The PR contains breaking changes, and I have bumped the MAJOR version in `version.json`. - [x] I have updated the examples in README with the latest module version number.
StephenWeatherford
pushed a commit
to StephenWeatherford/bicep-registry-modules
that referenced
this pull request
Jul 21, 2023
…d add optional params for MCA Multi Tenant Scenario (Azure#410) ## Description lz (sub) vending `v1.4.1` release - Change Template Metadata and add optional params for MCA Multi Tenant Scenario ## Downstream Artifcats - Release: https://github.com/Azure/bicep-lz-vending/releases/tag/v1.4.1 - PR: Azure/bicep-lz-vending#42 - Tests: https://github.com/Azure/bicep-lz-vending/actions/runs/5199625378/jobs/9377275161 cc: @StephenWeatherford and @shenglol ## Updating an existing module <!--Run through the checklist if your PR updates an existing module.--> - [ ] This is a bug fix: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [x] I have run `brm validate` locally to verify the module files. - [x] I have run deployment tests locally to ensure the module is deployable. - [x] I have read the [Updating an existing module](https://github.com/Azure/bicep-registry-modules/blob/main/CONTRIBUTING.md#updating-an-existing-module) section in the contributing guide and updated the `version.json` file properly: - [ ] The PR contains backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`. - [x] The PR contains backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] The PR contains breaking changes, and I have bumped the MAJOR version in `version.json`. - [x] I have updated the examples in README with the latest module version number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
Update Metadata for BRM Changes & Add Support for Subscription Request Creation for MCA Multi-Tenant Customers
This PR fixes/adds/changes/removes
main.bicep
for [Can't merge until next release] Modify brm tool to fully support description metadata for public registry modules bicep#10810 as below:a.
metadata.summary
>metadata.description
b.
metadata.description
>metadata.details
Breaking Changes
None
Testing Evidence
Tests will suffice
As part of this Pull Request I have
main
branch