Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪲 Bug Report - Creating subscriptions without networking resources causes management group placement and sub tags etc. to not be deployed/created #27

Closed
jtracey93 opened this issue Dec 4, 2022 · 0 comments · Fixed by #28
Assignees
Labels
Area: Management Groups Area: Non-Resource Specific things like tags, location etc. bug Something isn't working Status: Fixed

Comments

@jtracey93
Copy link
Collaborator

Describe the bug

Creating subscriptions without networking resources causes management group placement and sub tags etc. to not be deployed/created

To Reproduce

Steps to reproduce the behaviour:

Below example will create subscription fine, but will not move to corp MG or tag the subscription

targetScope = 'managementGroup'

module sub001 'br/public:lz/sub-vending:1.1.1' = {
  name: 'sub001'
  params: {
    subscriptionAliasEnabled: true
    subscriptionBillingScope: '/providers/Microsoft.Billing/billingAccounts/1234567/enrollmentAccounts/123456'
    subscriptionAliasName: 'sub-test-001'
    subscriptionDisplayName: 'sub-test-001'
    subscriptionTags: {
      example: 'true'
    }
    subscriptionWorkload: 'Production'
    subscriptionManagementGroupAssociationEnabled: true
    subscriptionManagementGroupId: 'corp'
  }
}

Expected behaviour

Above example should tag and move sub to correct MG

@jtracey93 jtracey93 added the bug Something isn't working label Dec 4, 2022
@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Dec 4, 2022
@jtracey93 jtracey93 added Area: Management Groups Area: Non-Resource Specific things like tags, location etc. and removed Needs: Triage 🔍 Needs triaging by the team labels Dec 4, 2022
jtracey93 added a commit that referenced this issue Dec 4, 2022
…s causes management group placement and sub tags etc. to not be deployed/created #27
@jtracey93 jtracey93 self-assigned this Dec 4, 2022
@ghost ghost added the Status: In PR label Dec 7, 2022
jtracey93 added a commit that referenced this issue Dec 7, 2022
* fix 🪲 Bug Report - `disableTelemetry` not being passed into child CARML modules and therefore some telemetry being left enabled #26

* fix 🪲 Bug Report - Creating subscriptions without networking resources causes management group placement and sub tags etc. to not be deployed/created #27

* Auto-update Bicep Module Docs for PR 28 [jtracey93/53f41446]

* update docs

* fix trailing whitespace

* Auto-update Bicep Module Docs for PR 28 [jtracey93/53f41446]

* move to single line

* Auto-update Bicep Module Docs for PR 28 [jtracey93/53f41446]

* change var name

* simplify

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
@ghost ghost added Status: Fixed and removed Status: In PR labels Dec 7, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jan 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Area: Management Groups Area: Non-Resource Specific things like tags, location etc. bug Something isn't working Status: Fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant