Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix irrelevant system error thrown in compute feature importances on LightGBM model training failure #3828

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

imatiach-msft
Copy link
Contributor

Fix irrelevant system error thrown in compute feature importances on LightGBM model training failure.
Resolve customer ICM where incorrect error message was displayed due to faulty logic added in PR #2929:

image

The logic it should instead be equivalent to:

if "Unknown label type: 'continuous'" in str(e) or "Unknown label type: continuous" in str(e):

NOT the current format which always falls into the if as true due to string not being checked:

if "Unknown label type: 'continuous'" or "Unknown label type: continuous" in str(e):

The underlying customer error was:
ValueError: Series.dtypes must be int, float or bool
but it was re-raised as the CONTINUOUS_ERR incorrectly.

Copilot summary:
This pull request includes changes to the compute_feature_importance.py file to improve error handling for continuous target columns when creating a LightGBM model. The most important changes include the introduction of a new error variant list and the modification of the error handling logic in the create_lightgbm_model function.

Error handling improvements:

Copy link

github-actions bot commented Feb 7, 2025

Test Results for model-monitoring-ci

63 tests   63 ✅  54s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit 232c980.

♻️ This comment has been updated with latest results.

Man-MSFT
Man-MSFT previously approved these changes Feb 7, 2025
Copy link

github-actions bot commented Feb 8, 2025

Test Results for model-monitoring-gsq-ci

13 tests   13 ✅  1h 27m 36s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit 90e75c1.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants