-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix irrelevant system error thrown in compute feature importances on LightGBM model training failure #3828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results for model-monitoring-ci63 tests 63 ✅ 54s ⏱️ Results for commit 232c980. ♻️ This comment has been updated with latest results. |
Man-MSFT
previously approved these changes
Feb 7, 2025
ycheng35xo
reviewed
Feb 7, 2025
assets/model_monitoring/components/src/feature_importance_metrics/compute_feature_importance.py
Show resolved
Hide resolved
Test Results for model-monitoring-gsq-ci13 tests 13 ✅ 1h 27m 36s ⏱️ Results for commit 90e75c1. ♻️ This comment has been updated with latest results. |
719846f
to
232c980
Compare
ycheng35xo
approved these changes
Feb 10, 2025
…LightGBM model training failure
232c980
to
90e75c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix irrelevant system error thrown in compute feature importances on LightGBM model training failure.
Resolve customer ICM where incorrect error message was displayed due to faulty logic added in PR #2929:
The logic it should instead be equivalent to:
NOT the current format which always falls into the if as true due to string not being checked:
The underlying customer error was:
ValueError: Series.dtypes must be int, float or bool
but it was re-raised as the CONTINUOUS_ERR incorrectly.
Copilot summary:
This pull request includes changes to the
compute_feature_importance.py
file to improve error handling for continuous target columns when creating a LightGBM model. The most important changes include the introduction of a new error variant list and the modification of the error handling logic in thecreate_lightgbm_model
function.Error handling improvements:
assets/model_monitoring/components/src/feature_importance_metrics/compute_feature_importance.py
: AddedCONTINUOUS_SYSTEM_ERR_VARIANTS
list to handle different error message formats for continuous target columns.assets/model_monitoring/components/src/feature_importance_metrics/compute_feature_importance.py
: Updated the error handling increate_lightgbm_model
to check againstCONTINUOUS_SYSTEM_ERR_VARIANTS
using theany
function.