Add RemotePath mount option #46
Conversation
|
The word Also did you test this change? |
|
RemotePath is part of the terminology of SMB (cf. https://technet.microsoft.com/en-us/library/jj635724(v=wps.630).aspx ). |
|
@zlatan I just took a major bugfix on the master branch. Do you mind rebasing and ping me when you do? |
|
@ahmetalpbalkan Rebase is ready. |
| @@ -298,6 +298,13 @@ func mount(accountName, accountKey, storageBase, mountPath string, options Volum | |||
| options.GID = "0" | |||
| } | |||
| mountURI := fmt.Sprintf("//%s.file.%s/%s", accountName, storageBase, options.Share) | |||
| if len(options.RemotePath) != 0 { | |||
| if options.RemotePath[0] != '/' { | |||
There was a problem hiding this comment.
@zlatan I believe you can use path.Join(.. , ..) here to append the slash without checking if it starts with a slash (it could be starting with multiple slashes too).
path.Join("//a.b.com/", "////b") -> //a.b.com/b
|
@zlatan mostly looks good, thank you very much. Can you please document it in README.md as well (especially since the terminology is a bit hard to understand in this case)? |
|
@ahmetalpbalkan README.md was updated, path.Join was used for concatenation of remotepath to mountURI. |
|
@zlatan thanks for following up. merging. |
|
@ahmetalpbalkan Thank you! |
I add an option remotepath which will allow us to use a specific directory in File Share as a volume in the docker container.