Skip to content
This repository has been archived by the owner on Jan 17, 2018. It is now read-only.

Do not remove mounted path recursivley after umount #24

Conversation

sascha-egerer
Copy link

Do not recursivly remove the mount-path after
unmounting it to prevent accidential data removal

Issue #23

Do not recursivly remove the mount-path after
unmounting it to prevent accidential data removal
@ahmetb
Copy link
Contributor

ahmetb commented Feb 29, 2016

@sascha-egerer do you think we should just do this or rather prevent duplicate mounts at the same mountpoint, somehow?

@sascha-egerer
Copy link
Author

Yes i think a recursive remove is a bad idea anyway.
You mount a share to an existing folder. This folder can contain content but is then overlayed with the mount - so no problem here so far. But if you now unmount and then recursivly remove that folder you may delete data that should not be removed.
You can now say "there should be no user content at this place" but i think it's better to throw an error then removing the data without any information.
So that has not really something to do with the duplicate mount as it may also be a problem if there is local data in that folder.

But yeah i'm not sure if that error has to be catched and must be prepared for a save driver fail...

@ahmetb
Copy link
Contributor

ahmetb commented Mar 1, 2016

Closing this in favor of #25. Thanks for the pull request anyway, we always appreciate!

@ahmetb ahmetb closed this Mar 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants