Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement custom authorizer for msal-go example #74

Merged
merged 1 commit into from
Jun 29, 2021
Merged

feat: implement custom authorizer for msal-go example #74

merged 1 commit into from
Jun 29, 2021

Conversation

aramase
Copy link
Member

@aramase aramase commented Jun 26, 2021

Signed-off-by: Anish Ramasekar [email protected]

@aramase aramase marked this pull request as ready for review June 26, 2021 00:51
@aramase aramase requested a review from sozercan June 28, 2021 17:17

// generate a token using the msal confidential client
// this will always generate a new token request to AAD
// TODO (aramase) consider using acquire token silent
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we link to an issue?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #76 and also added ref in the TODO

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit, LGTM

@aramase aramase enabled auto-merge (squash) June 29, 2021 15:05
@aramase aramase merged commit 5a1b5d1 into Azure:main Jun 29, 2021
@aramase aramase deleted the update-msal-go-demo branch June 29, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants