test: enable e2e on kind clusters and shellcheck #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
chewong
changed the title
sozercan
reviewed
May 11, 2021
Makefile
Outdated
| @@ -85,6 +91,7 @@ run: generate fmt vet manifests | |||
| .PHONY: deploy | |||
| deploy: $(KUBECTL) $(KUSTOMIZE) | |||
| $(MAKE) manifests install-cert-manager | |||
| @sleep 20 | |||
There was a problem hiding this comment.
We already have some wait statement in https://github.com/Azure/aad-pod-managed-identity/blob/main/Makefile#L155-L157 and the sleep was added on top of it due to the following error:
mutatingwebhookconfiguration.admissionregistration.k8s.io/aad-pi-webhook-mutating-webhook-configuration created
Error from server (InternalError): error when creating "STDIN": Internal error occurred: failed calling webhook "webhook.cert-manager.io": Post "https://cert-manager-webhook.cert-manager.svc:443/mutate?timeout=10s": dial tcp 10.96.71.140:443: connect: connection refused
Error from server (InternalError): error when creating "STDIN": Internal error occurred: failed calling webhook "webhook.cert-manager.io": Post "https://cert-manager-webhook.cert-manager.svc:443/mutate?timeout=10s": dial tcp 10.96.71.140:443: connect: connection refused
I only had this error when running kind on Mac but I don't see it when running it in our Linux agent. Removed the sleep for now but I will re-visit this in the future
Signed-off-by: Ernest Wong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ernest Wong [email protected]