Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update Azure Identity for Python content #1352

Merged
merged 1 commit into from
May 22, 2024

Conversation

scottaddie
Copy link
Member

The workload_identity_client_id parameter of DefaultAzureCredential is a better fit for this use case. Update the content accordingly, and conduct an edit pass too.

@scottaddie scottaddie requested review from aramase and enj as code owners May 17, 2024 15:29
@scottaddie scottaddie changed the title Update Azure Identity for Python content docs: Update Azure Identity for Python content May 17, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.55%. Comparing base (3874533) to head (831f6ba).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1352      +/-   ##
==========================================
+ Coverage   51.66%   52.55%   +0.88%     
==========================================
  Files          53       53              
  Lines        2938     2445     -493     
==========================================
- Hits         1518     1285     -233     
+ Misses       1378     1118     -260     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aramase
Copy link
Member

aramase commented May 22, 2024

/azp run

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aramase aramase merged commit 4677852 into Azure:main May 22, 2024
9 checks passed
@scottaddie scottaddie deleted the scottaddie/azure-identity-sdk branch May 22, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants