Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating ApplicationInsights to 2.21; decoupling ApplicationInsights package from Host #2916

Merged
merged 2 commits into from
Oct 12, 2022

Conversation

brettsam
Copy link
Member

@brettsam brettsam commented Sep 16, 2022

Bumping App Insights, but also changing the project to allow for it to be released independently of a WebJobs release.

@brettsam
Copy link
Member Author

Rather than do this here -- I've just updated it directly in Functions at Azure/azure-functions-host#8838

@brettsam brettsam closed this Oct 12, 2022
@brettsam
Copy link
Member Author

This appears to be confusing enough people that I'll re-open and submit it here. But if you stumble across this issue before the new nuget is published -- you can directly add references to the latest AppInsights packages in your WebJobs project to workaround this.

@fowl2
Copy link

fowl2 commented Dec 9, 2022

This appears to be confusing enough people that I'll re-open and submit it here. But if you stumble across this issue before the new nuget is published -- you can directly add references to the latest AppInsights packages in your WebJobs project to workaround this.

It would be really great if the release notes (and docs) made clear the best way of handling app insights dependencies!

@czb182
Copy link

czb182 commented Dec 9, 2022

I see this release in 3.0.34, but its not on nuget yet

@ilmax
Copy link

ilmax commented Feb 1, 2023

Hey @brettsam any update on this? This is fixing a critical functionality, it's has been merged 3 months ago and still no package update available. Why is this one taking so long?

@brettsam
Copy link
Member Author

brettsam commented Feb 1, 2023

You should be able to directly reference the newest App Insights in your project. I thought this change was a (major) convenience but didn't think it was blocking anything critical.

That being said -- I'll work on getting it released this week.

@ilmax
Copy link

ilmax commented Feb 1, 2023

Hey @brettsam thanks for the answer.

This is not blocking because there's a workaround but I think it's critical because the current state is broken by default. On top of that people need to spend a lot of time to find the workaround.

The underlying issue has been fixed months ago, so I was assuming a new release to be available soon after.

I am personally waiting for this to undo the workarounds.

Thank you

@brettsam
Copy link
Member Author

brettsam commented Feb 3, 2023

@ilmax -- I went to do this yesterday and realized that this package is still not fully released to Functions production (due to the holidays, which set things back a while). This is a requirement before we push these to nuget -- if we push to nuget too early, it can lead to runtime issues if a customer deploys a newer version than what's in prod.

The good news is there's only one release stage left so this should be good to go to nuget sometime next week.

@ilmax
Copy link

ilmax commented Feb 3, 2023

@brettsam thank you for the info!
Looking forward to it next week then.

@brettsam
Copy link
Member Author

Sorry for the additional delay. It's now published: https://www.nuget.org/packages/Microsoft.Azure.WebJobs.Logging.ApplicationInsights/3.0.34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants