packaging: add native debian package #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjp256
force-pushed
the
native-deb
branch
9 times, most recently
from
d968b30 to
324ea74
Compare
nmeyerhans
requested changes
Apr 19, 2024
cjp256
force-pushed
the
native-deb
branch
3 times, most recently
from
393c9ca to
03c291e
Compare
cjp256
force-pushed
the
native-deb
branch
4 times, most recently
from
2154369 to
d60d0e8
Compare
nmeyerhans
requested changes
May 3, 2024
There was a problem hiding this comment.
lintian detects the following warnings from groff on sid:
W: azure-nvme-utils: groff-message troff:<standard input>:50: warning: cannot select font 'C' [usr/share/man/man1/azure-nvme-id.1.gz:2]
W: azure-nvme-utils: groff-message troff:<standard input>:5: warning: cannot select font 'CB' [usr/share/man/man1/azure-nvme-id.1.gz:1]
W: azure-nvme-utils: groff-message troff:<standard input>:60: warning: cannot select font 'C' [usr/share/man/man1/azure-nvme-id.1.gz:3]
W: azure-nvme-utils: groff-message troff:<standard input>:72: warning: cannot select font 'C' [usr/share/man/man1/azure-nvme-id.1.gz:4]
This appears to be a pandoc issue and may be fixed upstream. I'm not sure if this can be worked around in the input file or not, but it's probably worth a try. You can see the warnings yourself with
$ man -l obj-x86_64-linux-gnu/doc/azure-nvme-id.1 > /dev/null
troff:<standard input>:5: warning: cannot select font 'CB'
troff:<standard input>:50: warning: cannot select font 'C'
troff:<standard input>:60: warning: cannot select font 'C'
troff:<standard input>:72: warning: cannot select font 'C'
cjp256
added a commit
to cjp256/azure-vm-utils
that referenced
this pull request
Jun 6, 2024
As pointed out by Noah in Azure#15, Debian packaging lints issues in the generated manpage due to formatting emitted by older versions of pandoc: jgm/pandoc#9020 While changes in recent versions of pandoc have improved the output, let's just take the generated output from pandoc 3.2 as a starting point and maintain it manually for the time being. This reduces friction for packaging and gives us flexibility if we wanted to do something in the manpage that pandoc doesn't support. Signed-off-by: Chris Patterson <[email protected]>
cjp256
added a commit
to cjp256/azure-vm-utils
that referenced
this pull request
Jun 6, 2024
As pointed out by Noah in Azure#15, Debian packaging lints issues in the generated manpage due to formatting emitted by older versions of pandoc: jgm/pandoc#9020 While changes in recent versions of pandoc have improved the output, let's just take the generated output from pandoc 3.2 as a starting point and maintain it manually for the time being. This reduces friction for packaging and gives us flexibility if we wanted to do something in the manpage that pandoc doesn't support. Allow manpages to be generated at build-time with -DGENERATE_MANPAGES=1. Signed-off-by: Chris Patterson <[email protected]>
cjp256
added a commit
to cjp256/azure-vm-utils
that referenced
this pull request
Jun 6, 2024
As pointed out by Noah in Azure#15, Debian packaging lints issues in the generated manpage due to formatting emitted by older versions of pandoc: jgm/pandoc#9020 While changes in recent versions of pandoc have improved the output, let's just take the generated output from pandoc 3.2 as a starting point and maintain it manually for the time being. This reduces friction for packaging and gives us flexibility if we wanted to do something in the manpage that pandoc doesn't support. Allow manpages to be generated at build-time with -DGENERATE_MANPAGES=1 which will make it easy to sync. Signed-off-by: Chris Patterson <[email protected]>
cjp256
added a commit
to cjp256/azure-vm-utils
that referenced
this pull request
Jun 6, 2024
As pointed out by Noah in Azure#15, Debian packaging lints issues in the generated manpage due to formatting emitted by older versions of pandoc: jgm/pandoc#9020 While changes in recent versions of pandoc have improved the output, let's just take the generated output from pandoc 3.2 as a starting point and maintain it manually for the time being. This reduces friction for packaging and gives us flexibility if we wanted to do something in the manpage that pandoc doesn't support. Allow manpages to be generated at build-time with -DGENERATE_MANPAGES=1 which will make it easy to sync. Signed-off-by: Chris Patterson <[email protected]>
cjp256
added a commit
to cjp256/azure-vm-utils
that referenced
this pull request
Jun 6, 2024
As pointed out by Noah in Azure#15, Debian packaging lints issues in the generated manpage due to formatting emitted by older versions of pandoc: jgm/pandoc#9020 While changes in recent versions of pandoc have improved the output, let's just take the generated output from pandoc 3.2 as a starting point and maintain it manually for the time being. This reduces friction for packaging and gives us flexibility if we wanted to do something in the manpage that pandoc doesn't support. Allow manpages to be generated at build-time with -DGENERATE_MANPAGES=1 which will make it easy to sync. Signed-off-by: Chris Patterson <[email protected]>
cjp256
added a commit
to cjp256/azure-vm-utils
that referenced
this pull request
Jun 6, 2024
As pointed out by Noah in Azure#15, Debian packaging lints issues in the generated manpage due to formatting emitted by older versions of pandoc: jgm/pandoc#9020 While changes in recent versions of pandoc have improved the output, let's just take the generated output from pandoc 3.2 as a starting point and maintain it manually for the time being. This reduces friction for packaging and gives us flexibility if we wanted to do something in the manpage that pandoc doesn't support. Allow manpages to be generated at build-time with -DGENERATE_MANPAGES=1 which will make it easy to sync. Signed-off-by: Chris Patterson <[email protected]>
cjp256
added a commit
to cjp256/azure-vm-utils
that referenced
this pull request
Jun 6, 2024
As pointed out by Noah in Azure#15, Debian packaging lints issues in the generated manpage due to formatting emitted by older versions of pandoc: jgm/pandoc#9020 While changes in recent versions of pandoc have improved the output, let's just take the generated output from pandoc 3.2 as a starting point and maintain it manually for the time being. This reduces friction for packaging and gives us flexibility if we wanted to do something in the manpage that pandoc doesn't support. Allow manpages to be generated at build-time with -DGENERATE_MANPAGES=1 which will make it easy to sync. Signed-off-by: Chris Patterson <[email protected]>
cjp256
added a commit
to cjp256/azure-vm-utils
that referenced
this pull request
Jun 6, 2024
As pointed out by Noah in Azure#15, Debian packaging lints issues in the generated manpage due to formatting emitted by older versions of pandoc: jgm/pandoc#9020 While changes in recent versions of pandoc have improved the output, let's just take the generated output from pandoc 3.2 as a starting point and maintain it manually for the time being. This reduces friction for packaging and gives us flexibility if we wanted to do something in the manpage that pandoc doesn't support. Allow manpages to be generated at build-time with -DGENERATE_MANPAGES=1 which will make it easy to sync. Signed-off-by: Chris Patterson <[email protected]>
cjp256
added a commit
to cjp256/azure-vm-utils
that referenced
this pull request
Jun 6, 2024
As pointed out by Noah in Azure#15, Debian packaging lints issues in the generated manpage due to formatting emitted by older versions of pandoc: jgm/pandoc#9020 While changes in recent versions of pandoc have improved the output, let's just take the generated output from pandoc 3.2 as a starting point and maintain it manually for the time being. This reduces friction for packaging and gives us flexibility if we wanted to do something in the manpage that pandoc doesn't support. Allow manpages to be generated at build-time with -DGENERATE_MANPAGES=1 which will make it easy to sync. Signed-off-by: Chris Patterson <[email protected]>
cjp256
added a commit
to cjp256/azure-vm-utils
that referenced
this pull request
Jun 6, 2024
As pointed out by Noah in Azure#15, Debian packaging lints issues in the generated manpage due to formatting emitted by older versions of pandoc: jgm/pandoc#9020 While changes in recent versions of pandoc have improved the output, let's just take the generated output from pandoc 3.2 as a starting point and maintain it manually for the time being. This reduces friction for packaging and gives us flexibility if we wanted to do something in the manpage that pandoc doesn't support. Allow manpages to be generated at build-time with -DGENERATE_MANPAGES=1 which will make it easy to sync. Signed-off-by: Chris Patterson <[email protected]>
Addressing with #27 |
For development purposes, add native debian packaging. - Add debian package metadata to /packaging/debian - Add build-deb.sh to /scripts/ to build the debs - Add github workflow to validate debs Signed-off-by: Chris Patterson <[email protected]>
cjp256
added a commit
to cjp256/azure-vm-utils
that referenced
this pull request
Jun 10, 2024
As pointed out by Noah in Azure#15, Debian packaging lints issues in the generated manpage due to formatting emitted by older versions of pandoc: jgm/pandoc#9020 While changes in recent versions of pandoc have improved the output, let's just take the generated output from pandoc 3.2 as a starting point and maintain it manually for the time being. This reduces friction for packaging and gives us flexibility if we wanted to do something in the manpage that pandoc doesn't support. Allow manpages to be generated at build-time with -DGENERATE_MANPAGES=1 which will make it easy to sync. Signed-off-by: Chris Patterson <[email protected]>
cjp256
added a commit
that referenced
this pull request
Jun 10, 2024
As pointed out by Noah in #15, Debian packaging lints issues in the generated manpage due to formatting emitted by older versions of pandoc: jgm/pandoc#9020 While changes in recent versions of pandoc have improved the output, let's just take the generated output from pandoc 3.2 as a starting point and maintain it manually for the time being. This reduces friction for packaging and gives us flexibility if we wanted to do something in the manpage that pandoc doesn't support. Allow manpages to be generated at build-time with -DGENERATE_MANPAGES=1 which will make it easy to sync. Signed-off-by: Chris Patterson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For development purposes, add native debian packaging.
Add build-deb.sh to /scripts/
Add debian package metadata to /packaging/debian
Add a starter manpage to /doc in markdown format, using pandoc to convert to manpage.
Add github workflow to validate debs.
Move azure-nvme-id.spec to /packaging/azurelinux. It may work for other RPM distros too, but will revisit structure upon validating Fedora, etc.