Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tlsio options when creating tlsio on macos #143

Merged
merged 1 commit into from
Apr 29, 2020

Conversation

yunhaoling
Copy link
Contributor

@bsiegel
Copy link
Member

bsiegel commented Mar 2, 2020

Probably want to wait on merging this and actually update our vendored copy of azure-uamqp-c, once it has updated its submoduled copy of azure-c-shared-utility

@yunhaoling
Copy link
Contributor Author

@bsiegel agreed, thanks for the suggestion.

I've already created a PR in the azure-c-shared-utility:
Azure/azure-c-shared-utility#427

but yet no one is reviewing it, I'll ping someone to see if I can get my PR reviewed.

@malthe
Copy link
Contributor

malthe commented Mar 17, 2020

@bsiegel this seems to have been merged upstream now.

@bsiegel
Copy link
Member

bsiegel commented Mar 17, 2020

Upstream azure-uampq-c library needs to pull in the updated submodule (issue is open, Azure/azure-uamqp-c#331). Once that's done we can then update our copy of azure-uamqp-c and unblock this.

@yunhaoling yunhaoling requested a review from annatisch April 28, 2020 23:39
@yunhaoling
Copy link
Contributor Author

yunhaoling commented Apr 29, 2020

hey @bsiegel, I need to merge this PR as we plan to do a release next week. There are people in github issue asking what's happening and expecting a fix. I don't want to keep the thread flying for a long time.

Here is more context:
actually we have deviated from azure-uamqp-c library -- we've made our own fixes in the C lib previously and not pulled their latest code in. (Because there're risks pulling in their latest code, some api got changed, extra efforts are needed to do the merge)

Probably in the future we could make a big PR to their repo including all our fixes. But right now I prefer our release plan not being blocked by the underlying C library.

@bsiegel
Copy link
Member

bsiegel commented Apr 29, 2020

Sounds good. I don't have a strong opinion since I don't actually own any code in this repo, but we should probably document somewhere the fixes we have applied on top of our dependencies, and which of those fixes have been accepted upstream. And also should file tasks to update those dependencies to the newer versions and re-apply any fixes that were not accepted upstream.

@yunhaoling yunhaoling merged commit a172f52 into Azure:master Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants