Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link desired capabilities support #361

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yunhaoling
Copy link
Contributor

@yunhaoling yunhaoling commented Dec 15, 2020

According to the amqp spec section 2.7.3 Attach -- Attach frame should support desired-capabilities:

image

This PR is to address the missing attach desired-capabilities support.

{
int result;

if (link == NULL)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (link == NULL)

There should probably be a check for desired_capabilities here also.


if (link == NULL)
{
LogError("NULL link");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rror("NULL link");

Consider logging desired_capabilities also.

@dcristoloveanu
Copy link
Member

Sorry for the long delay. I have not visited this repo in a bit :-).
Besides the 2 minor comments LGTM!

Copy link
Member

@dcristoloveanu dcristoloveanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants