Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File and dir setup methods #840

Merged
merged 6 commits into from
Jul 20, 2022
Merged

File and dir setup methods #840

merged 6 commits into from
Jul 20, 2022

Conversation

meganliu-msft
Copy link
Collaborator

  • basic testing in file_share_test.go

gapra-msft
gapra-msft reviewed Jul 18, 2022
View reviewed changes
component/azstorage/file_share.go
return syscall.ENOTSUP
log.Trace("FileShare::CreateDirectory : name %s", name)

metadata := make(azfile.Metadata)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's leave this out since it's not strictly necessary for functionality

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do other people think?

gapra-msft
gapra-msft reviewed Jul 18, 2022
View reviewed changes
Copy link
Member

@gapra-msft gapra-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, left a few small comments. We can aim to get the tests done at the end when you've implemented all the core methods.

@meganliu-msft meganliu-msft merged commit 1dd942d into filesFuseMain Jul 20, 2022
@meganliu-msft meganliu-msft deleted the fileAndDirSetupMethods branch July 20, 2022 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vibhansa-msft vibhansa-msft vibhansa-msft left review comments

@souravgupta-msft souravgupta-msft souravgupta-msft approved these changes

@gapra-msft gapra-msft gapra-msft approved these changes

@tasherif-msft tasherif-msft Awaiting requested review from tasherif-msft

Assignees
No one assigned
Labels
FileFuse V2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@meganliu-msft @gapra-msft @vibhansa-msft @souravgupta-msft