Autoconfig #1416
Merged
Autoconfig #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashruti-msft
requested review from
vibhansa-msft and
souravgupta-msft
as code owners
…torage-fuse into ashruti/autoConfig
…torage-fuse into ashruti/autoConfig
|
Can you also write tests for validating these options that are auto computed. For example, you can compute free memory using the |
souravgupta-msft
approved these changes
May 31, 2024
…to ashruti/autoConfig
souravgupta-msft
approved these changes
Jun 19, 2024
vibhansa-msft
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added calcultions for parameters for prefetch, parallelism, mem-size-mb, disk-size-mb in block_cache.
Updated test cases according to new calculations.
P.S: While printing blockCache configuations some values were in bytes and some in MB so I made the output uniform for all in bytes.