Build on OSX #72
Build on OSX #72
Conversation
Borrowed a lot from the cpprestsdk CMAKE, the changes revolved around: * using the correct OpenSSL, because homebrew installs it "Keg Only" * injecting a missing -L directive for gettext (libintl) * adding -DBOOST_LOG_DYN_LINK to make boost link properly * adding the same warnings/suppressions/cflags as Casablanca
Presumably this was preventing all builds from working, as the resources from the dat file were not being included because the #ifdef was failing.
|
Hi @guysherman, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution! TTYL, AZPRBOT; |
|
@guysherman, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
|
|
||
| ``` | ||
| brew install glibmm libxml++ libsigc++ ossp-uuid gettext openssl | ||
| ``` |
There was a problem hiding this comment.
glibmm is no longer used in our project, so is libsigc++.
There was a problem hiding this comment.
Can you let me know why gettext is needed?
There was a problem hiding this comment.
@hanzhumsft it seems the cmake was putting -lintl into the linker commands, which is part of gettext. I'll remove the references to glibmm and libsigc++.
|
Thanks a lot @guysherman for the PR. I gave some feedback inline. Please check. |
|
@hanzhumsft I will close this PR and raise two new ones, separating the two fixes in this one. |
This aims to fix #27 and #71
Borrowed a lot from the cpprestsdk CMAKE, the changes revolved around:
In resources.cpp changed _RECOURSES to _RESOURCES