Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling cmake for Win32 #26

Closed
wants to merge 4 commits into from
Closed

Conversation

southpolenator
Copy link

Changing CMakeLists.txt in order to enable cmake for Win32.
Fixing call to RpcStringFree in ANSI build. Replacing it with RpcStringFreeW.

@hanzhumsft
Copy link
Member

Hi @southpolenator , can you re-raise the PR against the new dev branch? This branch is open for community contributions.

BTW, if the PR has two unrelated changes, better to raise two different PRs.

@katmsft
Copy link
Member

katmsft commented Aug 16, 2018

This PR is no longer valid since the issue is resolved in 5.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants