-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update review process information #5898
Conversation
Co-authored-by: Anne Thompson <[email protected]>
@weshaggard CI is failing because the guiadence includes links to private repos. In this specific case, I think it is ok, but wanted to see if I am missing a guidelene or something that says we shouldn't target private links in public pages... |
We generally try to avoid protected links but if there are some exceptions that you want to include you can add them to the ignore list at https://github.com/Azure/azure-sdk/blob/main/eng/ignore-links.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added comments and requested some changes.
GH issues have been created for the remaining open questions.
Updated ignore list based on changes at Azure/azure-sdk#5898
The process here hasn't been updated in a while and is creating confussion with our Service Partners. I am sure there are more things that have changed, but for now, I am updating the information on how to schedule a meeting and the prerequisites so that it is closer to what we use in the Scheduler Tool: https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/667/Azure-SDK-Archboard-Review
I have talked to @ronniegeraghty before to see how we can just have one source of truth and unify the efforts.