Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update review process information #5898

Merged
merged 6 commits into from
Apr 18, 2023
Merged

Update review process information #5898

merged 6 commits into from
Apr 18, 2023

Conversation

maririos
Copy link
Member

@maririos maririos commented Apr 7, 2023

The process here hasn't been updated in a while and is creating confussion with our Service Partners. I am sure there are more things that have changed, but for now, I am updating the information on how to schedule a meeting and the prerequisites so that it is closer to what we use in the Scheduler Tool: https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/667/Azure-SDK-Archboard-Review

I have talked to @ronniegeraghty before to see how we can just have one source of truth and unify the efforts.

@maririos maririos marked this pull request as ready for review April 7, 2023 20:58
@maririos
Copy link
Member Author

@weshaggard CI is failing because the guiadence includes links to private repos. In this specific case, I think it is ok, but wanted to see if I am missing a guidelene or something that says we shouldn't target private links in public pages...

@weshaggard
Copy link
Member

@weshaggard CI is failing because the guidance includes links to private repos. In this specific case, I think it is ok, but wanted to see if I am missing a guideline or something that says we shouldn't target private links in public pages...

We generally try to avoid protected links but if there are some exceptions that you want to include you can add them to the ignore list at https://github.com/Azure/azure-sdk/blob/main/eng/ignore-links.txt

Copy link
Member

@ladonnaq ladonnaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added comments and requested some changes.

docs/policies/reviewprocess.md Show resolved Hide resolved
docs/policies/reviewprocess.md Outdated Show resolved Hide resolved
docs/policies/reviewprocess.md Outdated Show resolved Hide resolved
docs/policies/reviewprocess.md Outdated Show resolved Hide resolved
docs/policies/reviewprocess.md Show resolved Hide resolved
docs/policies/reviewprocess.md Show resolved Hide resolved
docs/policies/reviewprocess.md Outdated Show resolved Hide resolved
docs/policies/reviewprocess.md Show resolved Hide resolved
docs/policies/reviewprocess.md Outdated Show resolved Hide resolved
docs/policies/reviewprocess.md Show resolved Hide resolved
@maririos maririos requested a review from ladonnaq April 11, 2023 19:58
@maririos maririos dismissed ladonnaq’s stale review April 18, 2023 22:54

GH issues have been created for the remaining open questions.

@maririos maririos merged commit c03f8f2 into Azure:main Apr 18, 2023
weshaggard added a commit to Azure/azure-sdk-tools that referenced this pull request Apr 19, 2023
Updated ignore list based on changes at Azure/azure-sdk#5898
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants