-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android guidelines restructuring #2324
Conversation
…ce to the former from general_sidebar.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, pending resolution of comments.
@@ -41,47 +48,35 @@ The HTTP pipeline consists of a HTTP transport that is wrapped by multiple polic | |||
|
|||
### Supporting Types | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: you took out the TODO without adding the into sentence 😊 (also a couple places below)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed the Java guidelines do not have an introductory sentence for these sections and assumed it was not required. Do we still want to add one?
@annelo-msft I did remove the additional links from the |
I was looking at the published site as part of my status check - if you've generated the HTML and they're gone, then we're all good. Apologies for the false alarm. |
Fixes issue #482 from the Android repository.
Re-organized the Android guidelines following the @bsiegel's effort for iOS. There are a number of TODO items, but I think it's important to get the ball rolling with a PR to get valuable feedback. These guidelines took heavy inspiration from the iOS guidelines where appropriate, so much of the feedback given by @annelo-msft will be reflected here as well.