Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQ Guidelines Initiative: .NET TODOs #2095

Merged
merged 14 commits into from
Dec 8, 2020
Merged

MQ Guidelines Initiative: .NET TODOs #2095

merged 14 commits into from
Dec 8, 2020

Conversation

annelo-msft
Copy link
Member

Summary

Per the MQ Guidelines initiative to fill gaps in the guidelines across languages, we are moving to a new common structure for the guidelines and calling out areas where there are content gaps -- i.e. one or more of he other language guidelines have guidance that is not language-specific that is not represented in this language's guidelines.

This PR shifts the .NET sections into the new structure, fixes a few .md bugs, and adds the TODOs identifying gap areas.

This corresponds to the following work items:

New Structure

(Numbers for ease of reading here, but won't be shown in the guidelines page TOC)

Design

  1. Introduction
    1. Design Principles
    2. General Guidelines
    3. Non-HTTP Libraries
  2. Azure SDK API Design
    1. Service Client
      1. Service Client Constructors
      2. Service Methods
      3. Service Method Return Types
      4. Service Method Parameters
      5. Methods Returning Collections (Paging)
      6. Methods Invoking Long Running Operations
      7. Conditional Request Methods
    2. Supporting Types
      1. Model Types
      2. Enumerations
      3. Using Azure Core Types
      4. Using Primitive Types
    3. Exceptions (Errors)
    4. Authentication
    5. Namespaces
    6. Support for Mocking
    7. Hierarchical Clients
  3. Azure SDK Libraries (Packages)
    1. Packaging
    2. Versioning
    3. Dependencies
    4. Doc Comments
  4. Repository Guidelines
    1. Documentation Style
    2. README
    3. Samples

Implementation

  1. API Implementation
    1. Service Client
      1. Service Methods
        1. HttpPipeline
        2. HttpPipelinePolicy
      2. Service Method Parameters
        1. Parameter Validation
    2. Supporting Types
      1. Serialization
      2. Enumeration-like Structs
  2. SDK Feature Implementation
    1. Configuration
    2. Logging
    3. Distributed Tracing
    4. Telemetry
  3. Testing
  4. Language-specific other: Ecosystem Integration

Copy link
Member

@salameer salameer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part of MQ reorganization efforts

@@ -6,7 +6,79 @@ folder: dotnet
sidebar: general_sidebar
---

## Parameter validation {#dotnet-parameters}
## API Implementation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we rename these heading to "Implementation Considerations" or something like that? I would like to avoid having the term "API" used in this heading so readers don't think that this is the way to define the APIs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we can do that.

## Parameter validation {#dotnet-parameters}
## API Implementation

### The Service Client
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we expect to have content here by EOY? Do we expect any content any time soon? If by EOY or soon, I would add a TBD note pointing to a workitem issue in GitHub. If we don't have concrete plans for what to have in this section, I would remove the section, and simply start with the Using HttpPipeline section

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The thinking here was that the implementation TOC would largely mirror the design TOC, where Using HttpPipeline is a subsection of The Service Client (because that's what it's used inside of). I see your point, though, this looks empty without anything there. I'll add a TBD.

@annelo-msft annelo-msft merged commit 5e33a7e into Azure:master Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ArchBoard Guidelines Apply to PRs or Issues relating Archboard Guidelines MQ This issue is part of a "milestone of quality" initiative.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants