Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback user id lookup for test resource deployment #9700

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

benbp
Copy link
Member

@benbp benbp commented Jan 24, 2025

Add fallback user id lookup for test resource deployment

@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Jan 24, 2025
@benbp benbp self-assigned this Jan 24, 2025
@benbp benbp requested a review from a team as a code owner January 24, 2025 21:07
@benbp benbp requested a review from weshaggard January 24, 2025 21:07
@benbp benbp force-pushed the benbp/tr-user-id-fallback branch from 49444f0 to 84612b1 Compare January 27, 2025 20:11
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine as long as a user object with ID is always returned.

@benbp benbp force-pushed the benbp/tr-user-id-fallback branch from 84612b1 to 87ad898 Compare January 28, 2025 00:06
@benbp benbp force-pushed the benbp/tr-user-id-fallback branch from 87ad898 to 02e4e03 Compare January 28, 2025 00:07
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Jan 28, 2025
@benbp benbp enabled auto-merge (squash) January 28, 2025 19:45
@benbp benbp merged commit 6ecd9b2 into Azure:main Jan 28, 2025
8 checks passed
@benbp benbp deleted the benbp/tr-user-id-fallback branch January 28, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants