Non-Sparse Indirect Packages #9699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following pipelines have been queued for testing: |
benbp
approved these changes
Jan 27, 2025
This was referenced Jan 27, 2025
|
The following pipelines have been queued for testing: |
scbedd
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Jan 28, 2025
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#9699 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: Scott Beddall <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
js team needs the full (or at least MORE full) matrix as they want the indirectly changed packages to run both
nodeandbrowsertests.This code change, alone, would return them to the full matrix for indirect changes. However, I'm going to pair it with setting arguments to
IndirectFiltersto filter the full matrix down a bit to onlyUbuntuplatforms.This is in response to feedback from @jeremymeng WRT this pipeline. We need common changes to also run against browser (which it's not as evidenced by the linked PR).