handle only deleted files in a <language> - pullrequest build #9658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following pipelines have been queued for testing: |
benbp
approved these changes
Jan 17, 2025
This was referenced Jan 17, 2025
weshaggard
reviewed
Jan 20, 2025
weshaggard
approved these changes
Jan 21, 2025
scbedd
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Jan 21, 2025
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#9658 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Scott Beddall <[email protected]>
swathipil
pushed a commit
to swathipil/azure-sdk-tools
that referenced
this pull request
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In action
I think the only real discussion item here is whether to fold the deleted files directly under
ChangedFiles. I prefer it to be separate, as we can rely onChangedFilesactually resolving to a reference on disk. However for this usage it doesn't actually matter, as we don't rely on them existing on disk to check which package they belong to inGet-PrPackageProperties.Pending feedback from @weshaggard or @benbp , I have an opinion but I know ya'll will have one as well 👍
@kristapratico when I merge this (regardless of implementation detail) this PR will resolve the issue you saw over here.