Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeSpec specific conditions #9624

Merged
merged 1 commit into from
Jan 14, 2025
Merged

TypeSpec specific conditions #9624

merged 1 commit into from
Jan 14, 2025

Conversation

chidozieononiwu
Copy link
Member

@chidozieononiwu chidozieononiwu commented Jan 13, 2025 •
edited
Loading

  • Add labels to revision dropdown and allow only full diff for TypeSpec reviews

TypeSpec Revision DropDown

Copilot
Copilot AI reviewed Jan 13, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • src/dotnet/APIView/ClientSPA/src/app/_components/revision-options/revision-options.component.html: Language not supported
Comments suppressed due to low confidence (1)

src/dotnet/APIView/ClientSPA/src/app/_components/review-page-options/review-page-options.component.ts:258

  • The new method updateDiffStyle should be covered by tests to ensure it behaves as expected.
updateDiffStyle() {
maririos
maririos reviewed Jan 13, 2025
View reviewed changes
Copy link
Member

@maririos maririos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as always: UI preview and test (yay Copilot 😨 )

maririos
maririos approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@maririos maririos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unblocking the release for now

@chidozieononiwu chidozieononiwu self-assigned this Jan 14, 2025
@chidozieononiwu chidozieononiwu merged commit 256fc67 into Azure:main Jan 14, 2025
14 checks passed
@maorleger maorleger mentioned this pull request Feb 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@maririos maririos maririos approved these changes

@praveenkuttappan praveenkuttappan Awaiting requested review from praveenkuttappan

Assignees

@chidozieononiwu chidozieononiwu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chidozieononiwu @maririos