Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codeline Search #9605

Merged
merged 7 commits into from
Jan 28, 2025
Merged

Conversation

chidozieononiwu
Copy link
Member

@chidozieononiwu chidozieononiwu commented Jan 8, 2025

  • Add codeline search feature to APIView.
  • Allows search across lazy loaded items.

CommentSearch

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 14 changed files in this pull request and generated 1 comment.

Files not reviewed (9)
  • src/dotnet/APIView/APIViewWeb/Client/css/shared/theme-colors.scss: Language not supported
  • src/dotnet/APIView/ClientSPA/src/app/_components/code-panel/code-panel.component.html: Language not supported
  • src/dotnet/APIView/ClientSPA/src/app/_components/code-panel/code-panel.component.scss: Language not supported
  • src/dotnet/APIView/ClientSPA/src/app/_components/review-page-options/review-page-options.component.html: Language not supported
  • src/dotnet/APIView/ClientSPA/src/app/_components/review-page-options/review-page-options.component.scss: Language not supported
  • src/dotnet/APIView/ClientSPA/src/app/_components/review-page/review-page.component.html: Language not supported
  • src/dotnet/APIView/ClientSPA/src/ng-prime-overrides.scss: Language not supported
  • src/dotnet/APIView/ClientSPA/src/app/_modules/shared/review-page-layout.module.ts: Evaluated as low risk
  • src/dotnet/APIView/ClientSPA/src/app/_modules/shared/shared-app.module.ts: Evaluated as low risk
Comments suppressed due to low confidence (1)

src/dotnet/APIView/ClientSPA/src/app/_models/codeLineSearchInfo.ts:4

  • [nitpick] The property name matchedNodeIds could be more descriptive. Consider renaming it to matchedNodeIdSet to clearly indicate it is a Set.
matchedNodeIds: Set<string>

@chidozieononiwu chidozieononiwu self-assigned this Jan 8, 2025
Copy link
Member

@maririos maririos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a video of how it works and tests for the search section?

@chidozieononiwu chidozieononiwu force-pushed the accesibility/ReviewSearch branch from 7369fde to a2bf3bb Compare January 28, 2025 00:28
@chidozieononiwu chidozieononiwu merged commit 7f6ee75 into Azure:main Jan 28, 2025
8 checks passed
@chidozieononiwu chidozieononiwu deleted the accesibility/ReviewSearch branch January 28, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants