-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codeline Search #9605
Codeline Search #9605
Conversation
chidozieononiwu
commented
Jan 8, 2025
•
edited
Loading
edited
- Add codeline search feature to APIView.
- Allows search across lazy loaded items.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 14 changed files in this pull request and generated 1 comment.
Files not reviewed (9)
- src/dotnet/APIView/APIViewWeb/Client/css/shared/theme-colors.scss: Language not supported
- src/dotnet/APIView/ClientSPA/src/app/_components/code-panel/code-panel.component.html: Language not supported
- src/dotnet/APIView/ClientSPA/src/app/_components/code-panel/code-panel.component.scss: Language not supported
- src/dotnet/APIView/ClientSPA/src/app/_components/review-page-options/review-page-options.component.html: Language not supported
- src/dotnet/APIView/ClientSPA/src/app/_components/review-page-options/review-page-options.component.scss: Language not supported
- src/dotnet/APIView/ClientSPA/src/app/_components/review-page/review-page.component.html: Language not supported
- src/dotnet/APIView/ClientSPA/src/ng-prime-overrides.scss: Language not supported
- src/dotnet/APIView/ClientSPA/src/app/_modules/shared/review-page-layout.module.ts: Evaluated as low risk
- src/dotnet/APIView/ClientSPA/src/app/_modules/shared/shared-app.module.ts: Evaluated as low risk
Comments suppressed due to low confidence (1)
src/dotnet/APIView/ClientSPA/src/app/_models/codeLineSearchInfo.ts:4
- [nitpick] The property name
matchedNodeIds
could be more descriptive. Consider renaming it tomatchedNodeIdSet
to clearly indicate it is a Set.
matchedNodeIds: Set<string>
src/dotnet/APIView/ClientSPA/src/app/_components/review-page/review-page.component.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a video of how it works and tests for the search section?
src/dotnet/APIView/ClientSPA/src/app/_components/code-panel/code-panel.component.ts
Show resolved
Hide resolved
src/dotnet/APIView/ClientSPA/src/app/_components/code-panel/code-panel.component.ts
Outdated
Show resolved
Hide resolved
src/dotnet/APIView/ClientSPA/src/app/_components/code-panel/code-panel.component.ts
Outdated
Show resolved
Hide resolved
01b6637
to
f667188
Compare
f667188
to
7369fde
Compare
7369fde
to
a2bf3bb
Compare