Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows Path Issue in js-sdk-release-tool #9512

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Conversation

wanlwanl
Copy link
Member

@wanlwanl wanlwanl commented Dec 11, 2024

Bug: Falied to resolve correct path in windows
Fix: Use posix path as it is supported in all platforms

wanlwanl added a commit to Azure/azure-rest-api-specs that referenced this pull request Dec 11, 2024
@wanlwanl
Copy link
Member Author

wanlwanl commented Dec 12, 2024

@wanlwanl wanlwanl marked this pull request as ready for review December 12, 2024 03:12
Copy link
Member

@qiaozha qiaozha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wanlwanl wanlwanl enabled auto-merge (squash) December 12, 2024 11:29
@wanlwanl wanlwanl disabled auto-merge December 13, 2024 06:26
@wanlwanl wanlwanl enabled auto-merge (squash) December 13, 2024 06:26
@qiaozha
Copy link
Member

qiaozha commented Dec 13, 2024

/check-enforcer override

@wanlwanl wanlwanl merged commit 5c03031 into main Dec 13, 2024
4 checks passed
@wanlwanl wanlwanl deleted the wanl/fix-windows-path branch December 13, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants