Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Swift APIView] Convert Swift APIView to Tree Token structure #9506

Merged
merged 29 commits into from
Jan 9, 2025
Merged

[Swift APIView] Convert Swift APIView to Tree Token structure #9506

merged 29 commits into from
Jan 9, 2025

Conversation

tjprescott
Copy link
Member

@tjprescott tjprescott commented Dec 10, 2024 •
edited
Loading

Example APIView

TODO

  • Fix leading space on public keyword
  • Minimize token file size by ensuring default values aren't sent over the wire.
    - [ ] Wire up unit tests in CI so they run with each PR

@tjprescott tjprescott force-pushed the swift/treeTokenAPIView branch 2 times, most recently from 0b07b0f to 8ebdea3 Compare December 10, 2024 23:10
@tjprescott tjprescott force-pushed the swift/treeTokenAPIView branch from bac1e81 to eff6379 Compare December 12, 2024 19:54
@tjprescott tjprescott force-pushed the swift/treeTokenAPIView branch from 6fb95db to 67a3410 Compare December 13, 2024 22:14
@tjprescott tjprescott force-pushed the swift/treeTokenAPIView branch from 67a3410 to 4af4cc2 Compare December 13, 2024 23:00
@tjprescott tjprescott marked this pull request as ready for review December 30, 2024 19:48
@tjprescott tjprescott requested a review from a team as a code owner December 30, 2024 19:48
@tjprescott tjprescott merged commit 9708104 into main Jan 9, 2025
8 checks passed
@tjprescott tjprescott deleted the swift/treeTokenAPIView branch January 9, 2025 17:48
@maorleger maorleger mentioned this pull request Feb 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpodwysocki mpodwysocki mpodwysocki approved these changes

@praveenkuttappan praveenkuttappan Awaiting requested review from praveenkuttappan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjprescott @mpodwysocki