Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add step for emitting rate limits for a token #9354

Merged
merged 8 commits into from
Nov 14, 2024

Conversation

hallipr
Copy link
Member

@hallipr hallipr commented Nov 7, 2024

No description provided.

@hallipr hallipr requested a review from a team as a code owner November 7, 2024 21:43
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion but otherwise looks good.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Nov 8, 2024
@JimSuplizio JimSuplizio self-requested a review November 8, 2024 16:21
Copy link
Member

@JimSuplizio JimSuplizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hallipr we have a git-helpers.ps1 PowerShell script where we've been adding common git functions and I would rather see this added in there, as common code than inline. You might even be able to reuse or slightly modify some of the existing code to add this particular scenario.

@hallipr
Copy link
Member Author

hallipr commented Nov 14, 2024

@hallipr we have a git-helpers.ps1 PowerShell script where we've been adding common git functions and I would rather see this added in there, as common code than inline. You might even be able to reuse or slightly modify some of the existing code to add this particular scenario.

I'll open another PR to move the code to the helpers script.

@hallipr hallipr dismissed JimSuplizio’s stale review November 14, 2024 21:10

The child PRs were merged before this change was requested. Will implement in another PR.

@hallipr hallipr merged commit 91781f0 into Azure:main Nov 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants