Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable adaptive sampling to AppInsights #9339

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Conversation

hallipr
Copy link
Member

@hallipr hallipr commented Nov 6, 2024

Adaptive Sampling was causing PipelineWitness to drop a large portion of its happy-path telemetry before sending it to AppInsights. This made it difficult to search for trace messages related to specific build processing as there was a good chance that the trace logs from processing the build were sampled away.

By disabling adaptive sampling, we're telling the app to send all emitted telemetry to the AppInsights collector for processing.

@hallipr hallipr requested review from benbp and weshaggard November 7, 2024 23:09
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not exactly sure what this means but changes seems reasonable.

@hallipr
Copy link
Member Author

hallipr commented Nov 7, 2024

/check-enforcer override

@hallipr hallipr enabled auto-merge (squash) November 7, 2024 23:50
@hallipr hallipr merged commit 3b44d07 into Azure:main Nov 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants