-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Logging #9288
Merged
Merged
Update Logging #9288
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,40 +1,93 @@ | ||
function Test-SupportsDevOpsLogging() | ||
{ | ||
return ($null -ne $env:SYSTEM_TEAMPROJECTID) | ||
function Test-SupportsDevOpsLogging() { | ||
return ($null -ne $env:SYSTEM_TEAMPROJECTID) | ||
} | ||
|
||
function LogWarning | ||
{ | ||
if (Test-SupportsDevOpsLogging) | ||
{ | ||
Write-Host "##vso[task.LogIssue type=warning;]$args" | ||
} | ||
else | ||
{ | ||
Write-Warning "$args" | ||
} | ||
function Test-SupportsGitHubLogging() { | ||
return ($null -ne $env:GITHUB_ACTIONS) | ||
} | ||
|
||
function LogError | ||
{ | ||
if (Test-SupportsDevOpsLogging) | ||
{ | ||
Write-Host "##vso[task.LogIssue type=error;]$args" | ||
} | ||
else | ||
{ | ||
Write-Error "$args" | ||
} | ||
function LogInfo { | ||
Write-Host "$args" | ||
} | ||
|
||
function LogWarning { | ||
if (Test-SupportsDevOpsLogging) { | ||
Write-Host ("##vso[task.LogIssue type=warning;]$args" -replace "`n", "%0D%0A") | ||
} | ||
elseif (Test-SupportsGitHubLogging) { | ||
Write-Warning ("::warning::$args" -replace "`n", "%0D%0A") | ||
} | ||
else { | ||
Write-Warning "$args" | ||
} | ||
} | ||
|
||
function LogDebug | ||
function LogSuccess { | ||
$esc = [char]27 | ||
$green = "${esc}[32m" | ||
$reset = "${esc}[0m" | ||
|
||
Write-Host "${green}$args${reset}" | ||
} | ||
|
||
function LogErrorForFile($file, $errorString) | ||
{ | ||
if (Test-SupportsDevOpsLogging) | ||
{ | ||
Write-Host "[debug]$args" | ||
} | ||
else | ||
{ | ||
Write-Debug "$args" | ||
} | ||
if (Test-SupportsDevOpsLogging) { | ||
Write-Host ("##vso[task.logissue type=error;sourcepath=$file;linenumber=1;columnnumber=1;]$errorString" -replace "`n", "%0D%0A") | ||
} | ||
elseif (Test-SupportsGitHubLogging) { | ||
Write-Error ("::error file=$file,line=1,col=1::$errorString" -replace "`n", "%0D%0A") | ||
} | ||
else { | ||
Write-Error "[Error in file $file]$errorString" | ||
} | ||
} | ||
|
||
function LogError { | ||
if (Test-SupportsDevOpsLogging) { | ||
Write-Host ("##vso[task.LogIssue type=error;]$args" -replace "`n", "%0D%0A") | ||
} | ||
elseif (Test-SupportsGitHubLogging) { | ||
Write-Error ("::error::$args" -replace "`n", "%0D%0A") | ||
} | ||
else { | ||
Write-Error "$args" | ||
} | ||
} | ||
|
||
function LogDebug { | ||
if (Test-SupportsDevOpsLogging) { | ||
Write-Host "[debug]$args" | ||
} | ||
elseif (Test-SupportsGitHubLogging) { | ||
Write-Debug "::debug::$args" | ||
} | ||
else { | ||
Write-Debug "$args" | ||
} | ||
} | ||
|
||
function LogGroupStart() { | ||
if (Test-SupportsDevOpsLogging) { | ||
Write-Host "##[group]$args" | ||
} | ||
elseif (Test-SupportsGitHubLogging) { | ||
Write-Host "::group::$args" | ||
} | ||
} | ||
|
||
function LogGroupEnd() { | ||
if (Test-SupportsDevOpsLogging) { | ||
Write-Host "##[endgroup]" | ||
} | ||
elseif (Test-SupportsGitHubLogging) { | ||
Write-Host "::endgroup::" | ||
} | ||
} | ||
|
||
function LogJobFailure() { | ||
if (Test-SupportsDevOpsLogging) { | ||
Write-Host "##vso[task.complete result=Failed;]" | ||
} | ||
# No equivalent for GitHub Actions. Failure is only determined by nonzero exit code. | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if these show up in DevOps or github logs? I suspect these might only interpreted locally in a console window.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have verified it works on DevOps and GitHub Actions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does it look like there? Does it display those chars?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/chidozieononiwu/azure-sdk-tools/actions/runs/11603573286/job/32310793801#step:3:14
It just colors the log green.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok does that work in DevOps logs as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it does