Create-PrJobMatrix
#9281
Create-PrJobMatrix
#9281
Conversation
…rix. they are treated as the default, versus some PRMatrix setting that is manually set
…return a value. it's very spammy in use for a mostly null value
| @@ -170,10 +170,86 @@ function GetValueSafelyFrom-Yaml { | |||
| $current = $current[$key] | |||
| } | |||
| else { | |||
| Write-Host "The '$key' part of the path $($Keys -join "/") doesn't exist or is null." | |||
There was a problem hiding this comment.
@JimSuplizio FYI I know you did like this output.
This is very spammy when invoking for MatrixConfigs, as it is mostly null. I think that if the caller wants there to be a message about $null, they can log it.
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
| @@ -64,9 +64,7 @@ $packageProperties = Get-ChildItem -Recurse "$PackagePropertiesFolder" *.json ` | |||
|
|
|||
| # set default matrix config for each package if there isn't an override | |||
| $packageProperties | ForEach-Object { | |||
| if (-not $_.CIMatrixConfigs) { | |||
There was a problem hiding this comment.
I blindly took this and it definitely doesn't work. It's because CIMatrixConfigs isn't null, it's Empty Array.
This PR addresses a lot of the boilerplate code that would be necessary to distribute packages to one or multiple matrix files.
We allow our users to customize their platform using
ci.yml -> MatrixConfigsparams, but we don't honor those in the PR build (which is a single unified matrix).This PR allows the PR build to automatically use the correct matrix. Here it is in use.
Pardon the long runtime, I have further fixes from my other sdk-for-js branch that aren't there, which is why the builds are timing out. Nothing to do with this matrix logic 👍