Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix container image builds for http fault injector and otel collector #9096

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Fix container image builds for http fault injector and otel collector #9096

merged 2 commits into from
Oct 4, 2024

Conversation

benbp
Copy link
Member

@benbp benbp commented Oct 3, 2024

Fix image builds for http fault injector and otel collector

@benbp benbp requested a review from ckairen as a code owner October 3, 2024 21:01
@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Oct 3, 2024
@benbp benbp requested review from richardpark-msft and a team as code owners October 3, 2024 21:01
@benbp benbp self-assigned this Oct 3, 2024
@benbp
Copy link
Member Author

benbp commented Oct 3, 2024 •
edited
Loading

@richardpark-msft @lmolkova the otel builder is failing with:

##[error]#11 9.065 go: go.opentelemetry.io/collector/cmd/builder imports
##[error]#11 9.065 	go.opentelemetry.io/collector/receiver/otlpreceiver imports
##[error]#11 9.065 	go.opentelemetry.io/collector/config/configgrpc imports
##[error]#11 9.065 	go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc tested by
##[error]#11 9.065 	go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc.test imports
##[error]#11 9.065 	google.golang.org/grpc/interop imports
##[error]#11 9.065 	cloud.google.com/go/compute/metadata: ambiguous import: found package cloud.google.com/go/compute/metadata in multiple modules:
##[error]#11 9.065 	cloud.google.com/go v0.26.0 (/go/pkg/mod/cloud.google.com/[email protected]/compute/metadata)
##[error]#11 9.065 	cloud.google.com/go/compute/metadata v0.2.4-0.20230617002413-005d2dfb6b68 (/go/pkg/mod/cloud.google.com/go/compute/[email protected])

Most of the fixes I see are pulling in the dependency and running go mod tidy, but since we're doing a go install in the dockerfile that's not an option.

@richardpark-msft
Copy link
Member

@richardpark-msft @lmolkova the otel builder is failing with:

##[error]#11 9.065 go: go.opentelemetry.io/collector/cmd/builder imports
##[error]#11 9.065 	go.opentelemetry.io/collector/receiver/otlpreceiver imports
##[error]#11 9.065 	go.opentelemetry.io/collector/config/configgrpc imports
##[error]#11 9.065 	go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc tested by
##[error]#11 9.065 	go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc.test imports
##[error]#11 9.065 	google.golang.org/grpc/interop imports
##[error]#11 9.065 	cloud.google.com/go/compute/metadata: ambiguous import: found package cloud.google.com/go/compute/metadata in multiple modules:
##[error]#11 9.065 	cloud.google.com/go v0.26.0 (/go/pkg/mod/cloud.google.com/[email protected]/compute/metadata)
##[error]#11 9.065 	cloud.google.com/go/compute/metadata v0.2.4-0.20230617002413-005d2dfb6b68 (/go/pkg/mod/cloud.google.com/go/compute/[email protected])

Most of the fixes I see are pulling in the dependency and running go mod tidy, but since we're doing a go install in the dockerfile that's not an option.

I'll take a look - @lmolkova and I had that trimmed down to just Azure and even then, just specific collectors, so you'd think the Google cloud stuff wouldn't even show up.

Got it working with the latest, and specifying a specific version of …
bd108fc 
…the envprovider since, apparently, it versions separately from everything else.
@richardpark-msft
Copy link
Member

Okay, I pushed some changes.

I also updated it to the latest collector, which required me to specify compatible versions for the file and env file providers.

@benbp benbp merged commit 2e4cd58 into Azure:main Oct 4, 2024
14 checks passed
@benbp benbp deleted the benbp/fix-image-builds branch October 4, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardpark-msft richardpark-msft richardpark-msft approved these changes

@weshaggard weshaggard weshaggard approved these changes

@ckairen ckairen Awaiting requested review from ckairen ckairen is a code owner

@JimSuplizio JimSuplizio Awaiting requested review from JimSuplizio

@lmolkova lmolkova Awaiting requested review from lmolkova

Assignees

@benbp benbp

Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Azure SDK EngSys 🚢🎉
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benbp @richardpark-msft @weshaggard