[Pylint] Check client methods have approved name prefix #9081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge azure-sdk-tools main into main
Update working-main
8 tasks
l0lawrence
reviewed
Oct 8, 2024
tools/pylint-extensions/azure-pylint-guidelines-checker/tests/test_pylint_custom_plugins.py
Outdated
Show resolved
Hide resolved
l0lawrence
approved these changes
Oct 10, 2024
tools/pylint-extensions/azure-pylint-guidelines-checker/tests/test_pylint_custom_plugins.py
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors existing checker
ClientHasApprovedMethodNamePrefixto better fit guidelines, remove false positives, and ignore internal modules and class properties.Affected SDKs:
azure.cognitiveservices.language.textanalytics.text_analytics_client3 errorsazure.cognitiveservices.personalizer.personalizer_client1 errorIncludes some extra common prefixes/verbs: close, cancel, clear, subscribe, send, query
Includes prefixes/verbs for future use: analyze, train, detect