Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

091724/samples api view #9038

Merged
merged 2 commits into from
Oct 15, 2024
Merged

091724/samples api view #9038

merged 2 commits into from
Oct 15, 2024

Conversation

chidozieononiwu
Copy link
Member

@chidozieononiwu chidozieononiwu commented Sep 25, 2024 •
edited
Loading

  • Add sample Page to updated APIView UI

SamplesAPIView

@chidozieononiwu chidozieononiwu marked this pull request as ready for review September 26, 2024 21:04
@chidozieononiwu chidozieononiwu self-assigned this Sep 26, 2024
@maririos
Copy link
Member

maririos commented Oct 7, 2024

Could you add a GIF for the UI?

@chidozieononiwu chidozieononiwu force-pushed the 091724/SamplesAPIView branch 2 times, most recently from 80034ee to 762f2c3 Compare October 7, 2024 23:28
maririos
maririos approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@maririos maririos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small UI changes. We should try to keep the text using only caps on the first word of the sentence. This is something Crystal (our UI designer) taught us when we worked with her.

@chidozieononiwu
Add Samples APIView Page
d836a6a 
Samples Revison Select Panel

Pager options for samples

Add Samples MarkDown Page

Add Samples Add and Edit

Add Monaco Editor

Add Monaco Editor

Add Edit Samples View

Fix APIView tests

Samples PAge Update

Add commenting to code sections

Show comments and linenumbers in code sections

Commenting on Samples Page

CRUD for samples

Fix broken tests

Resolve PR comments
@chidozieononiwu chidozieononiwu merged commit e7f2d5e into Azure:main Oct 15, 2024
8 checks passed
@maorleger maorleger mentioned this pull request Feb 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maririos maririos maririos approved these changes

@praveenkuttappan praveenkuttappan praveenkuttappan approved these changes

@ckairen ckairen Awaiting requested review from ckairen

Assignees

@chidozieononiwu chidozieononiwu

Labels
None yet
Projects
Azure SDK EngSys 🤖🧠
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chidozieononiwu @maririos @praveenkuttappan