-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't verify changelogs for packages not present in Artifacts #9035
Conversation
Co-authored-by: Ben Broderick Phillips <[email protected]>
Co-authored-by: Ben Broderick Phillips <[email protected]>
The following pipelines have been queued for testing: |
The following pipelines have been queued for testing: |
The following pipelines have been queued for testing: |
…ot PSCustomObject like for using the yml directly
The following pipelines have been queued for testing: |
The following pipelines have been queued for testing: |
The following pipelines have been queued for testing: |
Last blocker ™️ for pipelinev3 in the python repo. Got clean runs other than failing changelog verification against packages that are no longer published.
Along the lines of this PR...should we have aShouldInvokeCHeck
function that takes anartifacts
property to check for? EGskipVerifyChangelog
not true,publishDocs
not `false. It's not necessarily common for each repo.If inCI
,yq
will be present.yq
a discoveredci.yml
on the flyIf not in CI, use PSModules and install the powershell module for ymlIf folks are good with above algo, I'll move theShouldInvokeCheck
tocommon.ps1
. Otherwise this PR should work as-is.The above may still stand, but we're just calling
yq
and erroring if not present on invoking machine in this PR now.