Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't verify changelogs for packages not present in Artifacts #9035

Merged
merged 8 commits into from
Sep 25, 2024

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Sep 24, 2024

Last blocker ™️ for pipelinev3 in the python repo. Got clean runs other than failing changelog verification against packages that are no longer published.

Along the lines of this PR...should we have a ShouldInvokeCHeck function that takes an artifacts property to check for? EG skipVerifyChangelog not true, publishDocs not `false. It's not necessarily common for each repo.

  • If in CI, yq will be present. yq a discovered ci.yml on the fly
  • If not in CI, use PSModules and install the powershell module for yml

If folks are good with above algo, I'll move the ShouldInvokeCheck to common.ps1. Otherwise this PR should work as-is.

The above may still stand, but we're just calling yq and erroring if not present on invoking machine in this PR now.

@scbedd scbedd requested a review from a team as a code owner September 24, 2024 18:39
@scbedd scbedd self-assigned this Sep 24, 2024
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants