Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dependabot-updates] Overriding the default behavior with dependabot.yml #9027

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

JackTn
Copy link
Member

@JackTn JackTn commented Sep 23, 2024

@weshaggard
Copy link
Member

@JackTn how does this dependabot configuration file fix the rush issue?

@JackTn JackTn changed the title [dependabot-updates] create dependabot.yml [dependabot-updates] Overriding the default behavior with dependabot.yml Sep 24, 2024
@JackTn
Copy link
Member Author

JackTn commented Sep 24, 2024

@weshaggard
We're utilizing overwrite default behavior through dependabot.yml, followed by Configuring each npm repository in rushjs. This approach is necessary because, although dependabot doesn't directly support rushjs repositories, it does work with npm repositories. For more details, please refer to this.

@weshaggard
Copy link
Member

@JackTn do we need to override it for all the directories or just the one where the error lives 2 ERROR <job_890274753> Error during file fetching; aborting: /tools/sdk-testgen/common/config/rush/package.json not found https://github.com/Azure/azure-sdk-tools/actions/runs/11016878832

@JackTn
Copy link
Member Author

JackTn commented Sep 25, 2024

@weshaggard To implement Dependabot across all our package directories, including C# projects, Go projects, Python projects, and JavaScript projects, and to address the RushJS issue, we need to set up to override settings for each directory. Do we write all setting into dependabot.yml ?

@JackTn
Copy link
Member Author

JackTn commented Sep 25, 2024

Through investigation, this repo probably has more than 100 configuration files like package.json !

@weshaggard
Copy link
Member

Perhaps my assumption is incorrect but I would only expect anything that isn't overridden in the config file to keep the defaults. I really do not want to have to maintain a list of all projects in this file.

If we cannot easily override only one directory then I suggest we fix that directory (ie. remove rush and only use plain npm) instead of adding this config file.

@weshaggard
Copy link
Member

Let's test only the one directory overriding.

@weshaggard weshaggard merged commit 08d3d51 into Azure:main Sep 25, 2024
3 checks passed
@weshaggard
Copy link
Member

Looks like the one entry worked and unblocked the dependabot update PRs. https://github.com/Azure/azure-sdk-tools/actions/runs/11042246460/job/30674194826

@weshaggard
Copy link
Member

I guess I should say it seemed to generate updates for test-gen but it doesn't seem to update others. Also all the test-gen updates seem to be failing CI currently so configuring this as npm doesn't correctly update the rush lock files. I was talking with Ray and he is going to check to see if it is still used and if so move it away from Rush.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants