Update projects targeting net6 to net8 - part3 #9021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimSuplizio
requested review from
praveenkuttappan,
weshaggard and
a team
as code owners
JimSuplizio
commented
Sep 20, 2024
| @@ -160,7 +160,7 @@ private async Task<byte[]> ReadAndValidateContentFromGitHubAsync(GitHubRule rule | |||
| return payloadContent; | |||
| } | |||
|
|
|||
| private SHA256CryptoServiceProvider sha256 = new SHA256CryptoServiceProvider(); | |||
| private SHA256 sha256 = SHA256.Create(); | |||
There was a problem hiding this comment.
In net8 the SHA256CryptoServiceProvider class is deprecated and they recommend using the SHA256CryptoServiceProvider's base class' Create method.
JimSuplizio
commented
Sep 20, 2024
| @@ -285,7 +285,7 @@ public async Task RouteAsync(Guid route, HttpRequest request) | |||
| payload | |||
| ); | |||
|
|
|||
| throw ex; | |||
| throw; | |||
There was a problem hiding this comment.
throw ex vs throw - The former loses the stack prior to the throw and, in net8, is now a warning. I'm assuming this was in error as it removes the relevant callstack
weshaggard
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
net6 hits EOL in November, 2024 and this is to update things to net8. This is the third round of projects.
Contributes to #8606