Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spelling: Remove deprecated --no-install, replace with --no #9013

Merged
merged 10 commits into from
Sep 24, 2024
Merged

Spelling: Remove deprecated --no-install, replace with --no #9013

merged 10 commits into from
Sep 24, 2024

Conversation

danieljurek
Copy link
Member

Fixes #6315

@danieljurek danieljurek requested a review from a team as a code owner September 19, 2024 17:17
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

benbp
benbp approved these changes Sep 19, 2024
View reviewed changes
eng/common/spelling/Invoke-Cspell.ps1 Outdated Show resolved Hide resolved
This was referenced Sep 19, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@danieljurek
Copy link
Member Author

Chatted w/ @weshaggard, going to:

  1. Convert tests to pester tests
  2. Fix how git changes are enumerated to decouple from DevOps pipeline variables

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@danieljurek
Copy link
Member Author

I refactored a bunch to get the tests into Pester. I'm curious to see if they pass in our pipelines as a lot of the code is coupled to both pipelines and error outputs (which can change when running in pipelines).

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@danieljurek
Copy link
Member Author

@weshaggard -- Have a look. I made a few changes and added the tests into the tools - eng-common-tests - ci pipeline. They do take a little longer than other tests but do not require authentication.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Sep 24, 2024
@azure-sdk @danieljurek
Sync eng/common directory with azure-sdk-tools for PR 9013 (#31167)
6a8dd2c 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#9013 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Daniel Jurek <[email protected]>
@danieljurek danieljurek merged commit c6132dd into main Sep 24, 2024
12 checks passed
@danieljurek danieljurek deleted the djurek/spelling-npx-no branch September 24, 2024 16:52
@danieljurek danieljurek mentioned this pull request Sep 24, 2024
Closed
@maorleger maorleger mentioned this pull request Feb 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hallipr hallipr hallipr left review comments

@weshaggard weshaggard weshaggard approved these changes

@mikeharder mikeharder mikeharder left review comments

@benbp benbp benbp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spell check should use --no in npx invocation
6 participants
@danieljurek @azure-sdk @benbp @hallipr @weshaggard @mikeharder