Ensure that ScanPaths are always populated in verify-readmes
#8998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t, and there are previous failures in the analyze pipeline, we won't properly invoke verify readmes.
|
The following pipelines have been queued for testing: |
This was referenced Sep 18, 2024
weshaggard
approved these changes
Sep 18, 2024
benbp
approved these changes
Sep 18, 2024
scbedd
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Sep 19, 2024
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#8998 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Scott Beddall <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happens if a task above the call to
verify-readmesfails? Well before this change we would SKIP populating the scan paths, which would then also cause the call to verify readmes to always fail because of no populated ScanPath argument.This PR matches up the condition to avoid this issue.