Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed the validation when use relative links #895

Merged
merged 27 commits into from
Sep 16, 2020
Merged

Failed the validation when use relative links #895

merged 27 commits into from
Sep 16, 2020

Conversation

sima-zhu
Copy link
Contributor

@sima-zhu sima-zhu commented Aug 18, 2020 •
edited
Loading

The PR is to enable the relative link check when set $checkLinkGuidance: $true.
The PR is pending on #870

The PR fixed #984 issue as well

@sima-zhu sima-zhu requested a review from a team as a code owner August 18, 2020 20:29
@sima-zhu sima-zhu requested a review from weshaggard August 18, 2020 20:29
@sima-zhu sima-zhu added the EngSys This issue is impacting the engineering system. label Aug 18, 2020
@sima-zhu sima-zhu mentioned this pull request Aug 19, 2020
Merged
This was referenced Sep 8, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@sima-zhu sima-zhu requested a review from weshaggard September 10, 2020 18:30
@sima-zhu sima-zhu changed the title Failed the validation when use relative links when enable the flag Failed the validation when use relative links Sep 14, 2020
@sima-zhu sima-zhu requested a review from weshaggard September 14, 2020 17:22
@sima-zhu sima-zhu mentioned this pull request Sep 14, 2020
Closed
weshaggard
weshaggard reviewed Sep 15, 2020
View reviewed changes
eng/common/pipelines/templates/steps/verify-links.yml Outdated
ScriptDirectory: 'eng/common/scripts'
Recursive: $false
Branchreplaceregex: '$(System.PullRequest.SourceRepositoryURI)'
Branchreplacementname: '$(System.PullRequest.SourceCommitId)'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't going to work. Remember why we needed to use env variables? It was because we need them to be empty if this is used outside of a PullRequest

@sima-zhu sima-zhu requested a review from weshaggard September 15, 2020 19:49
This was referenced Sep 15, 2020
Closed
Closed
Closed
@sima-zhu sima-zhu requested a review from weshaggard September 15, 2020 22:06
weshaggard
weshaggard approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last change request but otherwise looks good once you have finished your testing.

@sima-zhu sima-zhu merged commit 6240d7b into Azure:master Sep 16, 2020
@sima-zhu sima-zhu deleted the relative_link branch September 16, 2020 19:01
@sima-zhu sima-zhu mentioned this pull request Sep 21, 2020
Closed
6 tasks
sima-zhu pushed a commit to sima-zhu/azure-sdk-tools that referenced this pull request Dec 3, 2020
@ahsonkhan
Remove AZ_ERROR_MUTEX as it is no longer needed anymore. (Azure#895)
24c2c91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heaths heaths heaths approved these changes

@weshaggard weshaggard weshaggard approved these changes

@danieljurek danieljurek Awaiting requested review from danieljurek

Assignees

@sima-zhu sima-zhu

Labels
EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the misleading link logging in PR validation.
3 participants
@sima-zhu @heaths @weshaggard