Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add quotes to powershell args #8909

Merged
merged 1 commit into from
Aug 30, 2024
Merged

add quotes to powershell args #8909

merged 1 commit into from
Aug 30, 2024

Conversation

hallipr
Copy link
Member

@hallipr hallipr commented Aug 30, 2024

when ServiceDirectory is empty, powershell doesn't parse this command correctly

filePath: ${{ parameters.ScriptDirectory }}/Save-Package-Properties.ps1
arguments: >
  -ServiceDirectory ${{parameters.ServiceDirectory}}
  -OutDirectory ${{ parameters.PackageInfoDirectory }}

It's parsed like

Save-Package-Properties.ps1 -ServiceDirectory -OutDirectory ...

@hallipr hallipr marked this pull request as ready for review August 30, 2024 00:10
@hallipr hallipr requested a review from a team as a code owner August 30, 2024 00:10
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Aug 30, 2024
@hallipr hallipr merged commit 5dda57e into main Aug 30, 2024
10 checks passed
@hallipr hallipr deleted the users/pahallis/quotes branch August 30, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants