Fix issue in attribute line with attribute class name #8897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveenkuttappan
added
APIView
Central-EngSys
maririos
reviewed
Aug 27, 2024
| @@ -517,8 +517,10 @@ private void BuildAttributes(List<ReviewLine> reviewLines, ImmutableArray<Attrib | |||
| attributeLine.AddToken(ReviewToken.CreatePunctuationToken(SyntaxKind.EqualsToken)); | |||
| BuildTypedConstant(attributeLine, argument.Value); | |||
| } | |||
| attributeLine.Tokens.Last().HasSuffixSpace = false; | |||
There was a problem hiding this comment.
@christothes are there any other cases where there needs to be special considerations for attributes?
|
Review block for attribute with class looks like below with this fix. |
maririos
reviewed
Aug 28, 2024
tools/apiview/parsers/csharp-api-parser/CSharpAPIParserTests/CodeFileTests.cs
Show resolved
Hide resolved
maririos
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes following issue in attribute line
Attribute line is shown as
[AttributeUsage(AttributeTargets . Class ) ]instead of[AttributeUsage(AttributeTargets.Class )]