Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include RenderClasses in serialized JSON code file #8877

Merged
merged 1 commit into from
Aug 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/dotnet/APIView/APIView/Model/V2/ReviewToken.cs
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public ReviewToken(string value, TokenKind kind)
/// <summary>
/// Language specific style css class names
/// </summary>
public List<string> RenderClasses = [];
public List<string> RenderClasses { get; set; } = [];

public static ReviewToken CreateTextToken(string value, string navigateToId = null, bool hasSuffixSpace = true)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
using Newtonsoft.Json.Schema;
using Newtonsoft.Json.Linq;
using System.Text.Json.Serialization;
using APIView.Model.V2;


namespace CSharpAPIParserTests
Expand Down Expand Up @@ -126,5 +127,25 @@ private bool validateSchema(CodeFile codeFile)
}
return isValid;
}

[Fact]
public void TestNavigatonNodeHasRenderingClass()
{
var jsonString = JsonSerializer.Serialize(codeFile);
var parsedCodeFile = JsonSerializer.Deserialize<CodeFile>(jsonString);
Assert.Equal(8, CountNavigationNodes(parsedCodeFile.ReviewLines));
}

private int CountNavigationNodes(List<ReviewLine> lines)
{
int count = 0;
foreach (var line in lines)
{
var navTokens = line.Tokens.Where(x=> x.NavigationDisplayName != null);
count += navTokens.Count(x => x.RenderClasses.Any());
count += CountNavigationNodes(line.Children);
}
return count;
}
}
}
Loading