-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.NET API review parser changes to use new token schema #8850
Merged
praveenkuttappan
merged 10 commits into
Azure:main
from
praveenkuttappan:csharp_parser_schema_changes
Aug 22, 2024
Merged
.NET API review parser changes to use new token schema #8850
praveenkuttappan
merged 10 commits into
Azure:main
from
praveenkuttappan:csharp_parser_schema_changes
Aug 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveenkuttappan
added
APIView
Central-EngSys
This issue is owned by the Engineering System team.
labels
Aug 18, 2024
praveenkuttappan
requested review from
christothes and
chidozieononiwu
as code owners
August 18, 2024 02:58
praveenkuttappan
changed the title
.NET API review parser chagnes to use new token schema
.NET API review parser changes to use new token schema
Aug 19, 2024
I have added test cases to verify generated schema for Azure.Template and Azure.Storage.Blobs. |
christothes
reviewed
Aug 19, 2024
christothes
reviewed
Aug 19, 2024
christothes
reviewed
Aug 19, 2024
maririos
reviewed
Aug 19, 2024
tools/apiview/parsers/csharp-api-parser/CSharpAPIParser/Program.cs
Outdated
Show resolved
Hide resolved
christothes
reviewed
Aug 19, 2024
christothes
reviewed
Aug 19, 2024
christothes
reviewed
Aug 19, 2024
christothes
reviewed
Aug 19, 2024
christothes
reviewed
Aug 19, 2024
christothes
reviewed
Aug 19, 2024
christothes
reviewed
Aug 19, 2024
christothes
reviewed
Aug 19, 2024
christothes
reviewed
Aug 19, 2024
christothes
reviewed
Aug 19, 2024
christothes
reviewed
Aug 19, 2024
christothes
reviewed
Aug 19, 2024
christothes
reviewed
Aug 19, 2024
christothes
reviewed
Aug 19, 2024
tools/apiview/parsers/csharp-api-parser/CSharpAPIParser/TreeToken/CodeFileBuilder.cs
Outdated
Show resolved
Hide resolved
christothes
reviewed
Aug 19, 2024
tools/apiview/parsers/csharp-api-parser/CSharpAPIParser/TreeToken/CodeFileBuilder.cs
Outdated
Show resolved
Hide resolved
christothes
approved these changes
Aug 19, 2024
maririos
approved these changes
Aug 19, 2024
tools/apiview/parsers/csharp-api-parser/CSharpAPIParserTests/TestData.cs
Show resolved
Hide resolved
chidozieononiwu
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to modify .NET API review parser to create tokens based on new schema that's outlined in the PR #8816
Goal is to simplify token schema structure. Above PR also has sample token JSON file created as per the schema.
PR for changes to token models: #8852