Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

071824.01/conversation #8834

Merged
merged 7 commits into from
Aug 15, 2024
Merged

071824.01/conversation #8834

merged 7 commits into from
Aug 15, 2024

Conversation

chidozieononiwu
Copy link
Member

@chidozieononiwu chidozieononiwu commented Aug 14, 2024 •
edited
Loading

  • Add Conversation Page
    Conversation

@maririos maririos mentioned this pull request Aug 14, 2024
Closed
maririos
maririos reviewed Aug 14, 2024
View reviewed changes
src/dotnet/APIView/ClientSPA/src/app/_components/code-panel/code-panel.component.ts Show resolved Hide resolved
src/dotnet/APIView/ClientSPA/src/app/_components/conversations/conversations.component.html Outdated Show resolved Hide resolved
src/dotnet/APIView/ClientSPA/src/app/_components/conversations/conversations.component.html Show resolved Hide resolved
src/dotnet/APIView/ClientSPA/src/app/_components/conversations/conversations.component.html Show resolved Hide resolved
src/dotnet/APIView/ClientSPA/src/app/_components/conversations/conversations.component.html Outdated Show resolved Hide resolved
src/dotnet/APIView/ClientSPA/src/app/_components/conversations/conversations.component.spec.ts Show resolved Hide resolved
src/dotnet/APIView/ClientSPA/src/app/_components/conversations/conversations.component.spec.ts Show resolved Hide resolved
src/dotnet/APIView/ClientSPA/src/app/_components/review-page/review-page.component.html Show resolved Hide resolved
...APIView/ClientSPA/src/app/_components/shared/comment-thread/comment-thread.component.spec.ts Show resolved Hide resolved
@maririos
Copy link
Member

Moving forward could you add commits instead of force push so it is easier for a reviewer to see what has changed since the last review

@chidozieononiwu chidozieononiwu merged commit a62328f into Azure:main Aug 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maririos maririos maririos approved these changes

@praveenkuttappan praveenkuttappan Awaiting requested review from praveenkuttappan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chidozieononiwu @maririos