Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pylint] Disallow using legacy type hinting #8801

Merged
merged 6 commits into from
Aug 26, 2024

Conversation

MJoshuaB
Copy link
Contributor

@MJoshuaB MJoshuaB commented Aug 8, 2024

Addresses azure-sdk-for-python:#31104
Checks for uses of legacy (<Python 3.8) type hinting comments.

def function(self, max_wait_time, **kwargs):
     # type: (int, Any) -> None
     pass

@MJoshuaB MJoshuaB requested a review from l0lawrence as a code owner August 8, 2024 00:00
@MJoshuaB
Copy link
Contributor Author

MJoshuaB commented Aug 8, 2024

@microsoft-github-policy-service agree

@l0lawrence
Copy link
Member

l0lawrence commented Aug 16, 2024

/azp run tools - azure-pylint-guidelines-checker - ci

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

Copy link

No pipelines are associated with this pull request.

@swathipil
Copy link
Member

/azp run tools - azure-pylint-guidelines-checker - ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@l0lawrence l0lawrence merged commit 69ff96c into Azure:main Aug 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants