-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proxy audit log and other assorted fixes #8781
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the ordering we want
…portant events about a specific recording.
scbedd
commented
Aug 4, 2024
tools/test-proxy/Azure.Sdk.Tools.TestProxy/Properties/launchSettings.json
Outdated
Show resolved
Hide resolved
scbedd
changed the title
Add Proxy Audit Log
Add proxy audit log and other assorted fixes
Aug 5, 2024
scbedd
commented
Aug 5, 2024
alzimmermsft
reviewed
Aug 5, 2024
benbp
reviewed
Aug 5, 2024
mikeharder
approved these changes
Aug 5, 2024
benbp
approved these changes
Aug 5, 2024
scbedd
commented
Aug 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
stopped
while the last entry in the recording is still writing it's body. That location in the code has already obtained a lock on the session, so merely adding the same toplayback/stop
prevents the test from being stopped while the last entry is being streamed back. This was the source of theChannel Response timeout
issues thatjava- core
was seeing @alzimmermsft (at least, it has not reproed in the 3 core runs since I added this fix 🤞 )Record
code pathsjava - core
which beats the absolute hell out of the server.@mikeharder I need to add audit items to the
record
pathway, but I was laser focused on gettingplayback
concurrency issues resolved for the java folks. Please take a look, see how I'm retaining the various locks on resources (by reducing to a single access lock to each playback session). I think I've nailed most of the edge cases.@alzimmermsft looking at the latest
java - core
failures running with this version of the test-proxy, I don't think the proxy is related to those. I'm not declaring total victory with this PR but the issues are seriously reduced.This version is standing up to multiple storage runs: